Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete display_model and display_view #2752

Merged
merged 4 commits into from
Feb 11, 2020
Merged

Delete display_model and display_view #2752

merged 4 commits into from
Feb 11, 2020

Conversation

jasongrout
Copy link
Member

Fixes #2751

@jasongrout jasongrout added this to the 8.0 milestone Jan 25, 2020
@jasongrout jasongrout added the Work in Progress PRs that are not ready to be reviewed/merged. label Jan 25, 2020
@jasongrout
More work on deleting display_view and display_model.
2864b0c 
I decided to keep a display_view on the html manager for convenience, so people do not have to figure out how to use Lumino widget attach functions, or deal with Lumino widgets at all (which does mean that people are likely to not trigger resize messages properly too…)
@jasongrout jasongrout force-pushed the displayview branch 3 times, most recently from 1656ecd to 0e65d6b Compare January 25, 2020 16:29
@jasongrout
Copy link
Member Author

ReadTheDocs seems to be having issues, but all other tests pass.

@jasongrout jasongrout removed the Work in Progress PRs that are not ready to be reviewed/merged. label Jan 26, 2020
@jasongrout
Copy link
Member Author

I think this is ready for review, @vidartf @pbugnion @martinRenou (or whoever else wants to review it). The failing test is an unrelated readthedocs issue.

vidartf
vidartf reviewed Jan 31, 2020
View reviewed changes
Copy link
Member

@vidartf vidartf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good on a first scan. One comment on behaviour change that I think might have been unintended though.

packages/base-manager/src/manager-base.ts Show resolved Hide resolved
packages/html-manager/src/libembed.ts Show resolved Hide resolved
@jasongrout
Copy link
Member Author

Thanks for the review, @vidartf.

@jasongrout jasongrout merged commit fa3c706 into jupyter-widgets:master Feb 11, 2020
@philippjfr philippjfr mentioned this pull request May 4, 2020
Closed
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vidartf vidartf vidartf left review comments

Assignees
No one assigned
Labels
backwards-incompatible resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

display_view and display_model used inconsistently
2 participants
@jasongrout @vidartf