-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for diagnostic tags from LSP 3.15 #736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krassowski
force-pushed
the
improve-diagnostics
branch
from
December 30, 2021 16:28
f1fa9a3
to
1e84de1
Compare
and not the connection implementation detail
It looks like inclusion of pyls-memestra breaks LSP diagnostics on Windows. |
Yup, the
Which is basically QuantStack/pyls-memestra#50 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Add support for diagnostic tags (
DiagnosticTag
) from LSP 3.15.Code changes
Adds two new CSS classes:
cm-lsp-diagnostic-tag-Unnecessary
cm-lsp-diagnostic-tag-Deprecated
moves
severity
determination code so it is not run if we don't need to update the diagnostic.User-facing changes
TBD
Backwards-incompatible changes
None
Chores