Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DiagnosticTag.Deprecated #52

Closed
krassowski opened this issue Dec 30, 2021 · 1 comment · Fixed by #53
Closed

Use DiagnosticTag.Deprecated #52

krassowski opened this issue Dec 30, 2021 · 1 comment · Fixed by #53

Comments

@krassowski
Copy link
Contributor

LSP 3.15 enables special treatment of diagnostics for deprecated code using DiagnosticTags. By adding "tags": [2] you can tell the clients that the code is deprecated and the client can decorate it with strike-through. I am in a bit of a chicken and egg problem writing tests for this feature for JupyterLab-LSP (jupyter-lsp/jupyterlab-lsp#736) because most servers do not provide it yet; I thought it might be a good idea to implement if in pylsp-memestra early and test using it - what do you think?
@krassowski krassowski mentioned this issue Dec 30, 2021
Merged
@SylvainCorlay
Copy link
Member

That sounds like a great suggestion.

@krassowski krassowski mentioned this issue Dec 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deprecated tag from LSP 3.15 krassowski/pyls-memestra
2 participants
@SylvainCorlay @krassowski