Add deprecated tag from LSP 3.15 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the test failures, will updated the PR. |
|
Thanks @krassowski ! |
|
It seems test will need to be updated. |
|
cc @dharmaquark FYI |
|
I think it will be safe and useful to include it in a release rather than wait for a new pylsp version. I will add a logic to check for relevant |
|
Thanks, this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52; the end result with jupyter-lsp/jupyterlab-lsp#736 is:
For now I added the
DiagnosticTagenum in plugin.py but once python-lsp/python-lsp-server#142 is merged and released we can uselsp.DiagnosticTaginstead (or ideally try to import it and fallback toDiagnosticTagfor a while until the new version of pylsp is widely adopted).