fix warning errs from beta2

[kradalby]

Fixes #2065
Fixes #2064

Summary by CodeRabbit

• New Features
  • Enhanced configuration loading process for DNS settings, improving initialisation for user-specific configurations.
  • Improved handling of DNS resolver entries, streamlining control flow and reducing the risk of errors.

[coderabbitai]

Walkthrough

The changes involve modifications to the LoadConfig, GlobalResolvers, and SplitResolvers functions in the hscontrol/types/config.go file. Notably, the deprecated dns.use_username_in_magic_dns configuration key has been removed, affecting DNS initialisation. Additionally, the logic in the resolver functions has been enhanced to improve clarity and maintainability by explicitly controlling the flow when valid nameserver addresses are encountered.

Changes

Files	Change Summary
hscontrol/types/config.go	Removed default setting for dns.use_username_in_magic_dns; added continue statements in resolver functions.

Sequence Diagram(s)

sequenceDiagram
    participant A as User
    participant B as Config Loader
    participant C as Resolver

    A->>B: Load Config
    B->>C: Validate DNS Settings
    alt Valid Nameserver
        C-->>B: Append to resolvers
        B->>C: Continue to next entry
    else Invalid Nameserver
        C-->>B: Log error
    end

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Warn only if use_username_in_magic_dns is used (#[2065])	✅
NextDNS continues to work as before (#[2064])	❌	Changes may have affected DNS parsing.

Poem

In fields of code, where bunnies play,
Configs change and dance away.
A hop, a skip, the errors flee,
Clean DNS paths, as bright as can be!
So thank you, friends, for making right,
Our magic DNS shines so bright! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9bed76d and f3bb30e.

Files selected for processing (1)

• hscontrol/types/config.go (3 hunks)

Additional comments not posted (2)

hscontrol/types/config.go (2)

602-603: Improved control flow with continue statement.

The addition of the continue statement enhances the clarity and maintainability of the logic by explicitly skipping further processing for valid entries.

---

640-641: Improved control flow with continue statement.

The addition of the continue statement enhances the clarity and maintainability of the logic by explicitly skipping further processing for valid entries.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f3bb30e and 1b86535.

Files selected for processing (1)

• hscontrol/types/config.go (3 hunks)

Files skipped from review as they are similar to previous changes (1)

• hscontrol/types/config.go