[Bug] NextDNS does not work in 0.23.0-beta2

[mitchellkellett]

Is this a support request?

• This is not a support request

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

Since upgrading to 0.23.0-beta2 from 0.23.0-beta1, I now get this error in the logs.

2024-08-20T21:03:53Z WRN Invalid global nameserver "https://dns.nextdns.io/abc123". Parsing error: ParseAddr("https://dns.nextdns.io/abc123"): each colon-separated field must have at least one digit (at "https://dns.nextdns.io/abc123") ignoring

Expected Behavior

NextDNS continues to work like versions prior to 0.23.0-beta2.

Steps To Reproduce

1. Update config.yaml as per the new format.
2. Start Headscale 0.23.0-beta2.
3. Review logs.

Environment

- OS: Ubunutu 22.04
- Headscale version: 0.23.0-beta2
- Tailscale version: 1.70.0

Runtime environment

• Headscale is behind a (reverse) proxy
• Headscale runs in a container

Anything else?

config.yaml

~~~
dns:
  magic_dns: true
  base_domain: hs.net
  nameservers:
    global:
      - https://dns.nextdns.io/abc123
  search_domains: []
  extra_records: []
~~~

[mitchellkellett]

Updating the NextDNS url to "https://dns.nextdns.io/abc123" doesn't fix it either.

[kradalby]

I think this is an error in the warning condition and the nameserver is still added correctly? can you test if it works even tho you get the error?

[mitchellkellett]

Looks like it works, when I change it to the https version, I get the above error message printed twice in the log and then the usual start up messages. Nodes connect fine.

Navigating to https://test.nextdns.io gives me this.

{
	"status": "ok",
	"protocol": "DOH",
	"profile": "<Profile Removed>",
	"client": "<IPv6 Removed>",
	"srcIP": "<IPv6 Removed>",
	"anycast": true,
	"server": "vultr-syd-1",
	"clientName": "tailscale",
	"deviceName": "mk-mbp",
	"deviceID": "HVOPM",
	"deviceIP": "100.95.33.68",
	"deviceModel": "macOS"
}

[kradalby]

cool, I think I just missed a conditional cause a warning to be printet that wasnt needed.

[mitchellkellett]

Awesome, thanks for the quick fix.