Ensure DoH warnings are only emitted if err

Fixes #2064 Signed-off-by: Kristoffer Dalby <[email protected]>
juanfont · Aug 23, 2024 · f3bb30e · f3bb30e
1 parent bd4fad6
commit f3bb30e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/hscontrol/types/config.go b/hscontrol/types/config.go
@@ -599,6 +599,8 @@ func (d *DNSConfig) GlobalResolvers() []*dnstype.Resolver {
 			resolvers = append(resolvers, &dnstype.Resolver{
 				Addr: nsStr,
 			})
+
+			continue
 		} else {
 			warn = fmt.Sprintf("Invalid global nameserver %q. Parsing error: %s ignoring", nsStr, err)
 		}
@@ -635,6 +637,8 @@ func (d *DNSConfig) SplitResolvers() map[string][]*dnstype.Resolver {
 				resolvers = append(resolvers, &dnstype.Resolver{
 					Addr: nsStr,
 				})
+
+				continue
 			} else {
 				warn = fmt.Sprintf("Invalid split dns nameserver %q. Parsing error: %s ignoring", nsStr, err)
 			}