Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration of jsk_pcl_ros #1828

Closed
wants to merge 4 commits into from
Closed

Fix configuration of jsk_pcl_ros #1828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac79849
Fix order of cmake commands
wkentaro Aug 6, 2016
c54d279
Fix missing components in find_package
wkentaro Aug 6, 2016
a5a4489
Fix missing dependency declaration of jsk_pcl_ros
wkentaro Aug 6, 2016
fdadc61
Missing installation of executables
wkentaro Aug 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 71 additions & 21 deletions jsk_pcl_ros/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,47 @@ project(jsk_pcl_ros)
set(PCL_MSGS pcl_msgs) ## hydro and later

find_package(catkin REQUIRED COMPONENTS
jsk_recognition_utils jsk_pcl_ros_utils
dynamic_reconfigure pcl_ros nodelet message_generation genmsg
${PCL_MSGS} sensor_msgs geometry_msgs jsk_recognition_msgs
eigen_conversions tf_conversions tf2_ros tf
image_transport nodelet cv_bridge
jsk_topic_tools
cv_bridge
diagnostic_msgs
diagnostic_updater
dynamic_reconfigure
eigen_conversions
genmsg
geometry_msgs
image_geometry
jsk_footstep_msgs
image_transport
image_view2
interactive_markers
jsk_data
jsk_footstep_msgs
jsk_pcl_ros_utils
jsk_recognition_msgs
jsk_recognition_utils
jsk_topic_tools
kdl_conversions
kdl_parser
laser_assembler
octomap_server
octomap_ros
message_generation
ml_classifiers
moveit_core
nav_msgs
nodelet
octomap_msgs
kdl_parser
kdl_conversions
octomap_ros
octomap_server
pcl_conversions
${PCL_MSGS}
pcl_ros nodelet
rosboost_cfg
roscpp_tutorials
sensor_msgs
std_msgs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to add these lines? if other package depends on std_msgs, it think we do not have to do that again.

Copy link
Member Author

@wkentaro wkentaro Aug 7, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seems that jsk_pcl_ros explicitly depends on std_msgs, and this is necessary.

CMakeLists.txt:  std_msgs
CMakeLists.txt:  std_msgs
doc/nodes/hinted_handle_estimator.md:* `handle_length` (`std_msgs::Float64`)
doc/nodes/icp_registration.md:* `~output/latest_time` (`std_msgs/Float32`)
doc/nodes/icp_registration.md:* `~output/average_time` (`std_msgs/Float32`)
doc/nodes/normal_estimation_omp.md:* `~output/latest_time` (`std_msgs/Float32`)
doc/nodes/normal_estimation_omp.md:* `~output/average_time` (`std_msgs/Float32`)
doc/nodes/octree_voxel_grid.md:* `~output_resolution` (`std_msgs/Float32`)
doc/nodes/particle_filter_tracking.md:* `~output/latest_time` (`std_msgs/Float32`)
doc/nodes/particle_filter_tracking.md:* `~output/average_time` (`std_msgs/Float32`)
doc/nodes/particle_filter_tracking.md:* `~output/no_move` (`std_msgs/Bool`)
doc/nodes/particle_filter_tracking.md:* `~output/no_move_raw` (`std_msgs/Bool`)
doc/nodes/pointcloud_screenpoint.md:std_msgs/Header header
doc/nodes/region_growing_multiple_plane_segmentation.md:* `~output/latest_time` (`std_msgs/Float32`)
doc/nodes/region_growing_multiple_plane_segmentation.md:* `~output/average_time` (`std_msgs/Float32`)
doc/nodes/torus_finder.md:* `~output/latest_time` (`std_msgs/Float32`)
doc/nodes/torus_finder.md:* `~output/average_time` (`std_msgs/Float32`)
euslisp//collision-detector-client.l:                    :header (instance std_msgs::Header :init :stamp tm)
euslisp//collision-detector-client.l:                    :header (instance std_msgs::header :init :frame_id "" :stamp tm)
euslisp//collision-detector-client.l:(ros::subscribe "/collision_detector/collision_detector/collision_status" std_msgs::Bool #'publish-collision-status)
euslisp//pointcloud_screenpoint.l:    (send mrk :outline_color (instance std_msgs::ColorRGBA :init :r 0.0 :g 1.0 :b 0.0 :a 1.0))
euslisp//pointcloud_screenpoint.l:  (let* ((header (instance std_msgs::header :init
include//jsk_pcl_ros/attention_clipper.h:    virtual void publishBoundingBox(const std_msgs::Header& header);
include//jsk_pcl_ros/border_estimator.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/border_estimator.h:                              const std_msgs::Header& header);
include//jsk_pcl_ros/cluster_point_indices_decomposer.h:#include <std_msgs/ColorRGBA.h>
include//jsk_pcl_ros/cluster_point_indices_decomposer.h:     const std_msgs::Header header,
include//jsk_pcl_ros/cluster_point_indices_decomposer.h:    static uint32_t colorRGBAToUInt32(std_msgs::ColorRGBA c)
include//jsk_pcl_ros/collision_detector.h:#include <std_msgs/Bool.h>
include//jsk_pcl_ros/edge_depth_refinement.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/environment_plane_modeling.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/environment_plane_modeling.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/environment_plane_modeling.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/environment_plane_modeling.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/environment_plane_modeling.h:      const std::string& footprint_frame_id, const std_msgs::Header& header,
include//jsk_pcl_ros/environment_plane_modeling.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/environment_plane_modeling.h:    std_msgs::Header latest_global_header_;
include//jsk_pcl_ros/euclidean_cluster_extraction_nodelet.h:#include <std_msgs/ColorRGBA.h>
include//jsk_pcl_ros/extract_cuboid_particles_top_n.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/extract_cuboid_particles_top_n.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/heightmap_time_accumulation.h:      const cv::Mat& heightmap, const std_msgs::Header& header);
include//jsk_pcl_ros/hinted_handle_estimator.h:#include <std_msgs/Float64.h>
include//jsk_pcl_ros/icp_registration.h:#include <std_msgs/Float32.h>
include//jsk_pcl_ros/icp_registration.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/interactive_cuboid_likelihood.h:#include <std_msgs/Float32.h>
include//jsk_pcl_ros/keypoints_publisher.h:    std_msgs::Header input_header_;
include//jsk_pcl_ros/line_segment_collector.h:    virtual void collectFromBuffers(const std_msgs::Header& header,
include//jsk_pcl_ros/line_segment_collector.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/line_segment_collector.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/line_segment_detector.h:    LineSegment(const std_msgs::Header& input_header,
include//jsk_pcl_ros/line_segment_detector.h:    std_msgs::Header header;
include//jsk_pcl_ros/line_segment_detector.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/multi_plane_sac_segmentation.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/normal_estimation_omp.h:#include <std_msgs/Float32.h>
include//jsk_pcl_ros/octomap_server_contact.h:     std_msgs::ColorRGBA m_colorUnknown;
include//jsk_pcl_ros/organized_edge_detector.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/organized_edge_detector.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/organized_edge_detector.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/organized_edge_detector.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/organized_multi_plane_segmentation.h:                                                      const std_msgs::Header& header,
include//jsk_pcl_ros/organized_multi_plane_segmentation.h:                                      const std_msgs::Header& header,
include//jsk_pcl_ros/organized_multi_plane_segmentation.h:      const std_msgs::Header& header);
include//jsk_pcl_ros/organized_multi_plane_segmentation.h:                                    const std_msgs::Header& header);
include//jsk_pcl_ros/organized_multi_plane_segmentation.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/organized_multi_plane_segmentation.h:      const std_msgs::Header& header,
include//jsk_pcl_ros/particle_filter_tracking.h:#include <std_msgs/Float32.h>
include//jsk_pcl_ros/particle_filter_tracking.h:    virtual void publish_tracker_status(const std_msgs::Header& header,
include//jsk_pcl_ros/plane_supported_cuboid_estimator.h:                                  const std_msgs::Header& header);
include//jsk_pcl_ros/pointcloud_screenpoint.h:    std_msgs::Header header_;
include//jsk_pcl_ros/region_growing_multiple_plane_segmentation.h:#include <std_msgs/Float32.h>
include//jsk_pcl_ros/self_mask_named_link.h:     void assumeFrame(const std_msgs::Header& header) {
include//jsk_pcl_ros/tilt_laser_listener.h:    StampedJointAngle(const std_msgs::Header& header_arg, const double& value);
include//jsk_pcl_ros/tilt_laser_listener.h:    std_msgs::Header header;
package.xml:  <build_depend>std_msgs</build_depend>
package.xml:  <run_depend>std_msgs</run_depend>
sample//marker_model_tracking.l:                (object->marker-msg (send *cupboard* :translate #f(500 0 0)) (instance std_msgs::header :init :stamp (ros::time-now) :frame_id "/base_link")))
sample//sample_simulate_tabletop_cloud.py:from std_msgs.msg import Header
scripts//calculate_polygon_from_imu.py:from std_msgs.msg import Header
Binary file scripts//check_depth_error/test.bag matches
scripts//draw_3d_circle.py:from std_msgs.msg import ColorRGBA
scripts//test_contact_sensor.py:from std_msgs.msg import Header
scripts//tower_detect_viewer_server.py:from std_msgs.msg import Int16
scripts//tower_detect_viewer_server.py:from std_msgs.msg import String
scripts//tower_detect_viewer_server.py:from std_msgs.msg import Header
scripts//tracker_status_info.py:from std_msgs.msg import Float32
scripts//tracking_info.py:from std_msgs.msg import Float32
src//attention_clipper_nodelet.cpp:    const std_msgs::Header& header)
src//border_estimator_nodelet.cpp:    const std_msgs::Header& header)
src//border_estimator_nodelet.cpp:    const std_msgs::Header& header)
src//capture_stereo_synchronizer_nodelet.cpp:#include <std_msgs/Int32.h>
src//capture_stereo_synchronizer_nodelet.cpp:    pub_count_ = advertise<std_msgs::Int32>(
src//capture_stereo_synchronizer_nodelet.cpp:    std_msgs::Int32 count;
src//cluster_point_indices_decomposer_nodelet.cpp:   const std_msgs::Header header,
src//edge_depth_refinement_nodelet.cpp:    const std_msgs::Header& header)
src//edgebased_cube_finder_nodelet.cpp:      //     std_msgs::ColorRGBA green;
src//environment_plane_modeling_nodelet.cpp:    const std::string& footprint_frame, const std_msgs::Header& header,
src//environment_plane_modeling_nodelet.cpp:      const std_msgs::Header& header,
src//environment_plane_modeling_nodelet.cpp:    const std_msgs::Header& header, std::vector<GridPlane::Ptr>& grid_maps)
src//environment_plane_modeling_nodelet.cpp:    const std_msgs::Header& header,
src//environment_plane_modeling_nodelet.cpp:      const std_msgs::Header& header,
src//environment_plane_modeling_nodelet.cpp:    const std_msgs::Header& header,
src//extract_cuboid_particles_top_n_nodelet.cpp:    const std_msgs::Header& header)
src//extract_cuboid_particles_top_n_nodelet.cpp:    const std_msgs::Header& header)
src//heightmap_time_accumulation_nodelet.cpp:    const cv::Mat& heightmap, const std_msgs::Header& header)
src//hinted_handle_estimator_nodelet.cpp:    pub_length_ = advertise<std_msgs::Float64>(
src//hinted_handle_estimator_nodelet.cpp:        std_msgs::ColorRGBA temp_color;
src//hinted_handle_estimator_nodelet.cpp:    std_msgs::Float64 min_width_msg;
src//icp_registration_nodelet.cpp:    pub_latest_time_ = advertise<std_msgs::Float32>(
src//icp_registration_nodelet.cpp:    pub_average_time_ = advertise<std_msgs::Float32>(
src//icp_registration_nodelet.cpp:    const std_msgs::Header& header)
src//interactive_cuboid_likelihood_nodelet.cpp:    pub_ = pnh_->advertise<std_msgs::Float32>("output", 1);
src//interactive_cuboid_likelihood_nodelet.cpp:    std_msgs::Float32 float_msg;
src//line_segment_collector_nodelet.cpp:    const std_msgs::Header& header,
src//line_segment_collector_nodelet.cpp:    const std_msgs::Header& header,
src//line_segment_collector_nodelet.cpp:    const std_msgs::Header& header,
src//line_segment_detector_nodelet.cpp:    const std_msgs::Header& input_header,
src//line_segment_detector_nodelet.cpp:    const std_msgs::Header& header,
src//line_segment_detector_nodelet.cpp:      std_msgs::ColorRGBA color = jsk_topic_tools::colorCategory20(i);
src//linemod_nodelet.cpp:    std_msgs::Header dummy_header;
src//multi_plane_sac_segmentation_nodelet.cpp:    const std_msgs::Header& header,
src//normal_estimation_omp_nodelet.cpp:    pub_latest_time_ = advertise<std_msgs::Float32>(
src//normal_estimation_omp_nodelet.cpp:    pub_average_time_ = advertise<std_msgs::Float32>(
src//octomap_server_contact_nodelet.cpp:    std_msgs::Header tmpHeader;
src//octree_voxel_grid_nodelet.cpp:#include <std_msgs/Float32.h>
src//octree_voxel_grid_nodelet.cpp:    std_msgs::Float32 resolution;
src//octree_voxel_grid_nodelet.cpp:    pub_octree_resolution_ = advertise<std_msgs::Float32>(*pnh_, "output_resolution", 1);
src//organized_edge_detector_nodelet.cpp:    const std_msgs::Header& header)
src//organized_edge_detector_nodelet.cpp:    const std_msgs::Header& header)
src//organized_edge_detector_nodelet.cpp:    const std_msgs::Header& header,
src//organized_edge_detector_nodelet.cpp:    const std_msgs::Header& header,
src//organized_multi_plane_segmentation_nodelet.cpp:    const std_msgs::Header& header,
src//organized_multi_plane_segmentation_nodelet.cpp:    const std_msgs::Header& header,
src//organized_multi_plane_segmentation_nodelet.cpp:    const std_msgs::Header& header,
src//organized_multi_plane_segmentation_nodelet.cpp:    const std_msgs::Header& header,
src//organized_multi_plane_segmentation_nodelet.cpp:    const std_msgs::Header& header)
src//organized_multi_plane_segmentation_nodelet.cpp:    const std_msgs::Header& header)
src//particle_filter_tracking_nodelet.cpp:#include <std_msgs/Bool.h>
src//particle_filter_tracking_nodelet.cpp:    pub_latest_time_ = pnh_->advertise<std_msgs::Float32>(
src//particle_filter_tracking_nodelet.cpp:    pub_average_time_ = pnh_->advertise<std_msgs::Float32>(
src//particle_filter_tracking_nodelet.cpp:    pub_rms_angle_ = pnh_->advertise<std_msgs::Float32>(
src//particle_filter_tracking_nodelet.cpp:    pub_rms_distance_ = pnh_->advertise<std_msgs::Float32>(
src//particle_filter_tracking_nodelet.cpp:    pub_velocity_norm_ = pnh_->advertise<std_msgs::Float32>(
src//particle_filter_tracking_nodelet.cpp:    pub_no_move_raw_ = pnh_->advertise<std_msgs::Bool>(
src//particle_filter_tracking_nodelet.cpp:    pub_no_move_ = pnh_->advertise<std_msgs::Bool>(
src//particle_filter_tracking_nodelet.cpp:    pub_skipped_ = pnh_->advertise<std_msgs::Bool>(
src//particle_filter_tracking_nodelet.cpp:      std_msgs::Float32 velocity_norm;
src//particle_filter_tracking_nodelet.cpp:      std_msgs::Bool no_move_raw, no_move;
src//particle_filter_tracking_nodelet.cpp:    std_msgs::Float32 ros_distance_rms, ros_angle_rms;
src//particle_filter_tracking_nodelet.cpp:  void ParticleFilterTracking::publish_tracker_status(const std_msgs::Header& header,
src//plane_supported_cuboid_estimator_nodelet.cpp:    ParticleCloud::Ptr particles, int index, ros::Publisher& pub, const std_msgs::Header& header)
src//region_growing_multiple_plane_segmentation_nodelet.cpp:    pub_latest_time_ = advertise<std_msgs::Float32>(
src//region_growing_multiple_plane_segmentation_nodelet.cpp:    pub_average_time_ = advertise<std_msgs::Float32>(
src//tilt_laser_listener_nodelet.cpp:  StampedJointAngle::StampedJointAngle(const std_msgs::Header& header_arg, const double& value):
src//tilt_laser_listener_nodelet.cpp:    std_msgs::Header header;
src//tilt_laser_listener_nodelet.cpp:    std_msgs::Header header;
src//torus_finder_nodelet.cpp:    pub_latest_time_ = advertise<std_msgs::Float32>(
src//torus_finder_nodelet.cpp:    pub_average_time_ = advertise<std_msgs::Float32>(
srv//TransformScreenpoint.srv:std_msgs/Header header
test//test_attention_clipper.test:        args="/in_hand_clipper/output/point_indices /in_hand_clipper/output/point_indices_exists std_msgs/Bool 'len(m.indices) > 33000' --wait-for-start" />
test//test_euclidean_segmentation.test:        args="/euclidean_clustering/cluster_num /euclidean_clustering/cluster_num_assert std_msgs/Bool 'm.data > 20' --wait-for-start" />
test//test_euclidean_segmentation.test:        args="/euclidean_clustering/output/cluster_indices /euclidean_clustering/output/cluster_indices_assert std_msgs/Bool 'len(m) > 20' --wait-for-start" />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think explicit depends does not requires find_package nor
catkin_package
for example
https://github.com/ros-controls/ros_controllers/blob/kinetic-devel/velocity_controllers/include/velocity_controllers/joint_position_controller.h#L78
uses #include <std_msgs/Float64.h but std_msgs is not included in
https://github.com/ros-controls/ros_controllers/blob/kinetic-devel/velocity_controllers/CMakeLists.txt#L5-L27

◉ Kei Okada

On Sun, Aug 7, 2016 at 11:08 PM, Kentaro Wada [email protected]
wrote:

In jsk_pcl_ros/CMakeLists.txt
#1828 (comment)
:

octomap_msgs

  • kdl_parser
  • kdl_conversions
  • octomap_ros
  • octomap_server
  • pcl_conversions
  • ${PCL_MSGS}
  • pcl_ros nodelet
  • rosboost_cfg
  • roscpp_tutorials
  • sensor_msgs
  • std_msgs

I seems that jsk_pcl_ros explicitly depends on std_msgs, and this is
necessary.

CMakeLists.txt: std_msgs
CMakeLists.txt: DEPENDENCIES std_msgs sensor_msgs geometry_msgs jsk_recognition_msgs
CMakeLists.txt: CATKIN_DEPENDS std_msgs sensor_msgs geometry_msgs message_runtime jsk_recognition_msgs jsk_recognition_utils
euslisp//detection_interface.l: (instance std_msgs::header :init
euslisp//detection_interface.l: (instance std_msgs::header :init
euslisp//detection_interface.l: (instance std_msgs::header :init
euslisp//kalman-filtered-objectdetection-marker.l: (header (instance std_msgs::header :init))
euslisp//kalman-filtered-objectdetection-marker.l:(ros::subscribe "input/switch" std_msgs::Bool #'detect-switch-cb)
include//jsk_perception/color_histogram.h: const std_msgs::Header& header);
include//jsk_perception/color_histogram.h: const std_msgs::Header& header);
include//jsk_perception/color_histogram.h: const std_msgs::Header& header);
include//jsk_perception/color_histogram.h: const std_msgs::Header& header);
include//jsk_perception/grid_label.h: virtual void makeLabel(cv::Mat& label, const std_msgs::Header& header);
node_scripts//image_saver_sync:from std_msgs.msg import Header
node_scripts//image_time_diff.py:from std_msgs.msg import Header
node_scripts//publish_header:"""Publish std_msgs/Header with current timestamp.
node_scripts//publish_header:from std_msgs.msg import Header
node_scripts//rect_array_to_image_marker.py:from std_msgs.msg import ColorRGBA
package.xml: <build_depend>std_msgs</build_depend>
package.xml: <run_depend>std_msgs</run_depend>
Binary file sample//data/2016-06-10-23-01-28_in_lab.bag matches
Binary file sample//data/2016-06-10-23-01-28_in_lab.orig.bag matches
src//color_histogram.cpp: const std_msgs::Header& header)
src//color_histogram.cpp: const std_msgs::Header& header)
src//color_histogram.cpp: const std_msgs::Header& header)
src//color_histogram.cpp: const std_msgs::Header& header)
src//color_histogram_label_match.cpp: std_msgs::ColorRGBA coef_color = jsk_topic_tools::heatColor(coef);
src//colorize_float_image.cpp: std_msgs::ColorRGBA c = jsk_topic_tools::heatColor((v - min_value) / (max_value - min_value));
src//grid_label.cpp: void GridLabel::makeLabel(cv::Mat& label, const std_msgs::Header& header) {

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jsk-ros-pkg/jsk_recognition/pull/1828/files/5c8d7d04c921a71dee29025a37f9da0e73143e4e..26cb133674dfb49b96f46dda7e38e77d67530d87#r73802595,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeG3PD0KHBg3Vik3B_Ez9wAQtuf2RBIks5qdebzgaJpZM4JeUkQ
.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just a bug, don't you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comments, please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's if we really need std_msgs
#1846

◉ Kei Okada

On Tue, Aug 23, 2016 at 1:03 PM, Kentaro Wada [email protected]
wrote:

In jsk_pcl_ros/CMakeLists.txt
#1828 (comment)
:

octomap_msgs

  • kdl_parser
  • kdl_conversions
  • octomap_ros
  • octomap_server
  • pcl_conversions
  • ${PCL_MSGS}
  • pcl_ros nodelet
  • rosboost_cfg
  • roscpp_tutorials
  • sensor_msgs
  • std_msgs

Any comments, please?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jsk-ros-pkg/jsk_recognition/pull/1828/files/5c8d7d04c921a71dee29025a37f9da0e73143e4e..26cb133674dfb49b96f46dda7e38e77d67530d87#r75799730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeG3CO88COaqVDIZNFqJRR-R3mbf5Z1ks5qinD2gaJpZM4JeUkQ
.

Copy link
Member Author

@wkentaro wkentaro Aug 25, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know currently the std_msgs is not necessary because roscpp depends on it.
jsk_pcl_ros -> roscpp_tutorials -> roscpp -> std_msgs
But if they removed the dependency, the build will fail, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comments?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #1846, the commit ( 641cf00) has exactly same packages as original one, just change the order and format. and test (
https://travis-ci.org/jsk-ros-pkg/jsk_recognition/builds/154928142 ) seems Ok, though I haven't restarted 2 failed test,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems both tests passed build test, but failed in run_tests
https://travis-ci.org/jsk-ros-pkg/jsk_recognition/jobs/154928148, https://travis-ci.org/jsk-ros-pkg/jsk_recognition/jobs/154928146

std_srvs
stereo_msgs
tf
tf2_ros
tf_conversions
visualization_msgs
)
find_package(PkgConfig)
pkg_check_modules(ml_classifieres ml_classifiers QUIET)
Expand Down Expand Up @@ -115,6 +141,36 @@ generate_dynamic_reconfigure_options(
cfg/PointcloudDatabaseServer.cfg
)

generate_messages(DEPENDENCIES
${PCL_MSGS} sensor_msgs geometry_msgs jsk_recognition_msgs jsk_footstep_msgs)

catkin_package(
DEPENDS PCL
#
CATKIN_DEPENDS
diagnostic_msgs
geometry_msgs
pcl_ros
message_runtime
nav_msgs
octomap_msgs
${PCL_MSGS}
sensor_msgs
std_msgs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if other message depends on std_msgs, you do not have to add this again.

stereo_msgs
jsk_footstep_msgs
jsk_recognition_msgs
jsk_recognition_utils
visualization_msgs
#
INCLUDE_DIRS include
#
LIBRARIES
jsk_pcl_ros
jsk_pcl_ros_base
jsk_pcl_ros_moveit
)

find_package(OpenCV REQUIRED core imgproc)

include_directories(include ${catkin_INCLUDE_DIRS} ${OpenCV_INCLUDE_DIRS} ${PCL_INCLUDE_DIRS})
Expand Down Expand Up @@ -409,26 +465,20 @@ target_link_libraries(range_sensor_error_visualization jsk_pcl_ros)
add_executable(depth_camera_error_visualization tool/depth_camera_error_visualization.cpp)
target_link_libraries(depth_camera_error_visualization jsk_pcl_ros)

generate_messages(DEPENDENCIES
${PCL_MSGS} sensor_msgs geometry_msgs jsk_recognition_msgs jsk_footstep_msgs)

get_property(dirs DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES)
message("flags: ${CMAKE_CXX_FLAGS}")

catkin_package(
DEPENDS pcl
CATKIN_DEPENDS pcl_ros message_runtime ${PCL_MSGS} sensor_msgs geometry_msgs jsk_recognition_msgs jsk_recognition_utils
INCLUDE_DIRS include
LIBRARIES jsk_pcl_ros jsk_pcl_ros_base jsk_pcl_ros_moveit
)

# download and install sample data
add_custom_target(install_sample_data ALL COMMAND ${PROJECT_SOURCE_DIR}/scripts/install_sample_data.py)

install(DIRECTORY include/${PROJECT_NAME}/
DESTINATION ${CATKIN_PACKAGE_INCLUDE_DESTINATION})
install(TARGETS jsk_pcl_ros jsk_pcl_ros_base jsk_pcl_ros_moveit
${jsk_pcl_nodelet_executables}
bench_ransac_plane_estimation
depth_camera_error_visualization
range_sensor_error_visualization
sample_cube_nearest_point
RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}
ARCHIVE DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}
LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION})
Expand Down
2 changes: 2 additions & 0 deletions jsk_pcl_ros/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
<build_depend>octomap_ros</build_depend>
<build_depend>jsk_pcl_ros_utils</build_depend>
<build_depend>jsk_data</build_depend>
<build_depend>genmsg</build_depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to add genmsg ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from build_depend and find_package.


<!-- <run_depend>pcl</run_depend> -->
<run_depend>eigen_conversions</run_depend>
Expand Down Expand Up @@ -113,6 +114,7 @@
<run_depend>jsk_pcl_ros_utils</run_depend>
<run_depend>jsk_data</run_depend>
<test_depend>jsk_tools</test_depend>
<test_depend>rostest</test_depend>
<export>
<nodelet plugin="${prefix}/jsk_pcl_nodelets.xml"/>
<cpp lflags="-Wl,-rpath,${prefix}/lib -L${prefix}/lib -ljsk_pcl_ros" cflags="-I${prefix}/include"/>
Expand Down