Mapbox 2.2: Add sky layer as an option in threebox #232
Comments
|
Not so bad! 🤗🤗🤗 Perfect alignment |
jscastro76
changed the title
jscastro76
added a commit
that referenced
this issue
Apr 11, 2021
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs. **WARNING**: This version updates to Mapbox **2.2.0**. Despite v1.11.1 still supported, if used, some features from mapbox v.2.0.1 won't be obviously available such as sky layers. **Known issue**: `BuildingShadow` wont work as the definition of the layers has changed. #### ✨ Enhancements Add a better light for night on 14-buildingshadow.html example #118 - #146 Update to Mapbox 2.2 - #225 Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions - #226 Mapbox 2.2: Update all the examples (14-buildingshadow & 17-azuremaps not updated) - #232 Mapbox 2.2: Add sky layer as an option in threebox - Updated example [07-alignmentTest.html](https://github.com/jscastro76/threebox/blob/master/examples/07-alignmentTest.html) - Updated example [12-add3dmodel.html](https://github.com/jscastro76/threebox/blob/master/examples/12-add3dmodel.html) - Updated example [13-eiffel.html](https://github.com/jscastro76/threebox/blob/master/examples/13-eiffel.html) - #224 Ignore worker_threads - #229 tb.dispose() in dev mode not working. It was removed from three.js but not included in migration guide. - #234 Update all the examples to include antialias: true in the webglcontext #### 🪲 Bug fixes - #223 Can't resolve worker threads - #230 Module not found: Can't resolve 'worker_threads' (duplicated #223) #### 📝 Documentation - Updated [documentation](/examples/readme.md) (Added a note on the examples updated to Mapbox 2.2.0) - Updated [Threebox documentation](/docs/Threebox.md) (public cdns data, `sky` attribute and property, `tb.createSkyLayer`, `tb.getSunSky`, `tb.updateSunSky`, `tb.updateLightHelper`, ) - Updated [Examples](/examples) documentation (new sky layers in 7, 12, 13).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the solution you'd like
Sky layers is one of the best additions on Mapbox v2.2.0. It requires to create a new layer, and update it with the sun position if a concrete time/location is given.
Sky layer should be included optionally in threebox through an initialization attribute, but also as a separate property.
Ideally, this layer could be automatically synchronized by Threebox when
realSunlight: true.Additional context
There are some examples that already use
realSunlight, those should be updated to include this option and show the usage.07-alignmenttest.html12-add3dmodel.html13-eiffel.htmlIt should work without
realSunlight, but then it will take the time of the map center by default.defaultLights: trueThe text was updated successfully, but these errors were encountered: