Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions #225

Closed
jscastro76 opened this issue Apr 7, 2021 · 0 comments
Closed

Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions #225

jscastro76 opened this issue Apr 7, 2021 · 0 comments
Assignees
@jscastro76
Labels
📑 code improvement 🔗 external dependencies
Milestone
v2.2.2.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Apr 7, 2021 •
edited
Loading

To move to Mapbox 2.2. #146 it's needed to adapt to new depth calculation of the transformation matrixes
To keep compatibility with previous versions of Mapbox already deployed, CameraSync should check the mapbox version being executed through mapboxgl.version
@jscastro76 jscastro76 added this to the v2.2.2. milestone Apr 7, 2021
@jscastro76 jscastro76 self-assigned this Apr 7, 2021
@jscastro76 jscastro76 changed the title Mapbox 2.2 Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions Apr 7, 2021
jscastro76 added a commit that referenced this issue Apr 7, 2021
@jscastro76
- #146 Update to Mapbox 2.2
6ecf9a9 
  - #225 Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions
  - #226 Mapbox 2.2: Update all the examples (14-buildingshadow & 17-azuremaps not updated)

#### 📝 Documentation
- Updated [documentation](/examples/readme.md) (Added a note on the examples updated to Mapbox 2.2.0)
jscastro76 added a commit that referenced this issue Apr 11, 2021
@jscastro76
## 2.2.2
1ac396b 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

**WARNING**: This version updates to Mapbox **2.2.0**. Despite v1.11.1 still supported, if used, some features from mapbox v.2.0.1 won't be obviously available such as sky layers.
**Known issue**: `BuildingShadow` wont work as the definition of the layers has changed.

#### ✨ Enhancements

Add a better light for night on 14-buildingshadow.html example #118
- #146 Update to Mapbox 2.2
  - #225 Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions
  - #226 Mapbox 2.2: Update all the examples (14-buildingshadow & 17-azuremaps not updated)
  - #232 Mapbox 2.2: Add sky layer as an option in threebox
  - Updated example [07-alignmentTest.html](https://github.com/jscastro76/threebox/blob/master/examples/07-alignmentTest.html)
  - Updated example [12-add3dmodel.html](https://github.com/jscastro76/threebox/blob/master/examples/12-add3dmodel.html)
  - Updated example [13-eiffel.html](https://github.com/jscastro76/threebox/blob/master/examples/13-eiffel.html)
- #224 Ignore worker_threads
- #229 tb.dispose() in dev mode not working. It was removed from three.js but not included in migration guide.
- #234 Update all the examples to include antialias: true in the webglcontext

#### 🪲 Bug fixes
- #223 Can't resolve worker threads
- #230 Module not found: Can't resolve 'worker_threads' (duplicated #223)

#### 📝 Documentation
- Updated [documentation](/examples/readme.md) (Added a note on the examples updated to Mapbox 2.2.0)
- Updated [Threebox documentation](/docs/Threebox.md) (public cdns data, `sky` attribute and property, `tb.createSkyLayer`, `tb.getSunSky`, `tb.updateSunSky`, `tb.updateLightHelper`, )
- Updated [Examples](/examples) documentation (new sky layers in 7, 12, 13).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
📑 code improvement 🔗 external dependencies
Projects
None yet
Milestone
v2.2.2.
Development

No branches or pull requests
1 participant
@jscastro76