Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapbox 2.2: Update all the examples #226

Closed
18 of 20 tasks
jscastro76 opened this issue Apr 7, 2021 · 0 comments
Closed
18 of 20 tasks

Mapbox 2.2: Update all the examples #226

jscastro76 opened this issue Apr 7, 2021 · 0 comments
Assignees
@jscastro76
Labels
📑 code improvement 🔗 external dependencies 🏃 example
Milestone
v2.2.2.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Apr 7, 2021 •
edited
Loading

To move to Mapbox 2.2. #146 it's needed to update the links in all the examples and test them properly

  • example 01-basic.html
  • example 02-line.html
  • example 03-tube.html
  • example 04-mercator.html
  • example 05-logistics.html
  • example 06-object3d.html
  • example 07-alignmentTest.html
  • example 08-2dBuildings.html
  • example 09-raycaster.html
  • example 10-stylechange.html
  • example 11-animation.html
  • example 12-add3dmodel.html
  • example 13-eiffel.html
  • example 14-buildingshadow.html cannot be updated yet, until shader is changed
  • example 15-performance.html
  • example 16-multilayer.html
  • example 17-azuremaps.html cannot be updated as Azure Maps embedded mapbox version is 1.11
  • example 18-extrusions.html
  • example 19-fixedzoom.html
  • example 20-game.html
@jscastro76 jscastro76 added this to the v2.2.2. milestone Apr 7, 2021
@jscastro76 jscastro76 self-assigned this Apr 7, 2021
jscastro76 added a commit that referenced this issue Apr 7, 2021
@jscastro76
- #146 Update to Mapbox 2.2
6ecf9a9 
  - #225 Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions
  - #226 Mapbox 2.2: Update all the examples (14-buildingshadow & 17-azuremaps not updated)

#### 📝 Documentation
- Updated [documentation](/examples/readme.md) (Added a note on the examples updated to Mapbox 2.2.0)
jscastro76 added a commit that referenced this issue Apr 11, 2021
@jscastro76
## 2.2.2
1ac396b 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

**WARNING**: This version updates to Mapbox **2.2.0**. Despite v1.11.1 still supported, if used, some features from mapbox v.2.0.1 won't be obviously available such as sky layers.
**Known issue**: `BuildingShadow` wont work as the definition of the layers has changed.

#### ✨ Enhancements

Add a better light for night on 14-buildingshadow.html example #118
- #146 Update to Mapbox 2.2
  - #225 Mapbox 2.2: Update Depth calculation keeping compatibility with previous versions
  - #226 Mapbox 2.2: Update all the examples (14-buildingshadow & 17-azuremaps not updated)
  - #232 Mapbox 2.2: Add sky layer as an option in threebox
  - Updated example [07-alignmentTest.html](https://github.com/jscastro76/threebox/blob/master/examples/07-alignmentTest.html)
  - Updated example [12-add3dmodel.html](https://github.com/jscastro76/threebox/blob/master/examples/12-add3dmodel.html)
  - Updated example [13-eiffel.html](https://github.com/jscastro76/threebox/blob/master/examples/13-eiffel.html)
- #224 Ignore worker_threads
- #229 tb.dispose() in dev mode not working. It was removed from three.js but not included in migration guide.
- #234 Update all the examples to include antialias: true in the webglcontext

#### 🪲 Bug fixes
- #223 Can't resolve worker threads
- #230 Module not found: Can't resolve 'worker_threads' (duplicated #223)

#### 📝 Documentation
- Updated [documentation](/examples/readme.md) (Added a note on the examples updated to Mapbox 2.2.0)
- Updated [Threebox documentation](/docs/Threebox.md) (public cdns data, `sky` attribute and property, `tb.createSkyLayer`, `tb.getSunSky`, `tb.updateSunSky`, `tb.updateLightHelper`, )
- Updated [Examples](/examples) documentation (new sky layers in 7, 12, 13).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
📑 code improvement 🔗 external dependencies 🏃 example
Projects
None yet
Milestone
v2.2.2.
Development

No branches or pull requests
1 participant
@jscastro76