Deprecate tb.setLayerZoomVisibility, overlaps with tb.toggleLayer
#134
Comments
jscastro76
added a commit
that referenced
this issue
Dec 6, 2020
- add options.rotate and options.scale for Objects3D #126 - Create a new example with Three.js extrusions based on standard geoJson #127 Added a new example [17-extrusions.html](https://github.com/jscastro76/threebox/blob/master/examples/17-extrusions.html) - Convert internal variables (`selectedObject`, `draggedObject`, ...) into instance variables #130 - Deprecate `tb.setLayerZoomVisibility`, overlaps with `tb.toggleLayer` #134 - when an object is wireframed, all its clones are too #124 - Error when wireframing all the objects #131 - While dragging an object if mouse overs a label it stops dragging #132 - A layer shouldn't be shown explicitely if it's not in the right zoom range #133
jscastro76
added a commit
that referenced
this issue
Dec 9, 2020
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs. #### ✨ Enhancements - #125 three.js draw geojson. - #126 add options.rotate and options.scale for Objects3D. - #127 Create a new example with Three.js extrusions based on standard geoJson. Added a new example [17-extrusions.html](https://github.com/jscastro76/threebox/blob/master/examples/17-extrusions.html) - #130 Convert internal variables (`selectedObject`, `draggedObject`, ...) into instance variables . - #134 Deprecate `tb.setLayerZoomVisibility`, overlaps with `tb.toggleLayer`. - #138 expose `SunCalc.toJulian` #### 🪲 Bug fixes - #124 when an object is wireframed, all its clones are too. - #131 Error when wireframing all the objects. - #132 While dragging an object if mouse overs a label it stops dragging. - #133 A layer shouldn't be shown explicitely if it's not in the right zoom range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
tb.setLayerZoomVisibilitymethod overlaps with toggleLayer that could be both checks, visibility and zoomRange. It was an internal method called frommap.onZoomEndandtb.setLayerZoomRangeso it was not really used from client sideThe text was updated successfully, but these errors were encountered: