Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when wireframing all the objects #131

Closed
jscastro76 opened this issue Dec 5, 2020 · 0 comments
Closed

Error when wireframing all the objects #131

jscastro76 opened this issue Dec 5, 2020 · 0 comments
Assignees
@jscastro76
Labels
🪲 bug Something isn't working 🔍 needs investigation
Milestone
v.2.1.2.

Comments

@jscastro76
Copy link
Owner

jscastro76 commented Dec 5, 2020 •
edited
Loading

image

It's due probably because of the CSS2DObjects

whatever the model I'm trying to wireframe, it has no obj.model to traverse
image
@jscastro76 jscastro76 added 🪲 bug Something isn't working 🔍 needs investigation labels Dec 5, 2020
@jscastro76 jscastro76 self-assigned this Dec 5, 2020
@jscastro76 jscastro76 added this to the v.2.1.2. milestone Dec 5, 2020
jscastro76 added a commit that referenced this issue Dec 6, 2020
@jscastro76
- three.js draw geojson #125
af6b29d 
- add options.rotate and options.scale for Objects3D #126
- Create a new example with Three.js extrusions based on standard geoJson #127 Added a new example [17-extrusions.html](https://github.com/jscastro76/threebox/blob/master/examples/17-extrusions.html)
- Convert internal variables (`selectedObject`, `draggedObject`, ...) into instance variables #130
- Deprecate `tb.setLayerZoomVisibility`, overlaps with `tb.toggleLayer` #134
- when an object is wireframed, all its clones are too #124
- Error when wireframing all the objects #131
- While dragging an object if mouse overs a label it stops dragging #132
- A layer shouldn't be shown explicitely if it's not in the right zoom range #133
jscastro76 added a commit that referenced this issue Dec 9, 2020
@jscastro76
## 2.1.2
42ac721 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements

- #125 three.js draw geojson.
- #126 add options.rotate and options.scale for Objects3D.
- #127 Create a new example with Three.js extrusions based on standard geoJson. Added a new example [17-extrusions.html](https://github.com/jscastro76/threebox/blob/master/examples/17-extrusions.html)
- #130 Convert internal variables (`selectedObject`, `draggedObject`, ...) into instance variables .
- #134 Deprecate `tb.setLayerZoomVisibility`, overlaps with `tb.toggleLayer`.
- #138 expose `SunCalc.toJulian`

#### 🪲 Bug fixes

- #124 when an object is wireframed, all its clones are too.
- #131 Error when wireframing all the objects.
- #132 While dragging an object if mouse overs a label it stops dragging.
- #133 A layer shouldn't be shown explicitely if it's not in the right zoom range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscastro76 jscastro76

Labels
🪲 bug Something isn't working 🔍 needs investigation
Projects
None yet
Milestone
v.2.1.2.
Development

No branches or pull requests
1 participant
@jscastro76