Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when an object is wireframed, all its clones are too #124

Closed
jscastro76 opened this issue Dec 3, 2020 · 0 comments
Closed

when an object is wireframed, all its clones are too #124

jscastro76 opened this issue Dec 3, 2020 · 0 comments
Labels
🪲 bug Something isn't working

Comments

@jscastro76
Copy link
Owner

This is due to the optimization work. We should think on a solution that allows to replace the materials when a single object is wireframed and then return to the original instances of the materials when it's texturized again. Probably using userData to store that original Material
@jscastro76 jscastro76 changed the title when an object is wireframed, all it's clones are too when an object is wireframed, all its clones are too Dec 4, 2020
@jscastro76 jscastro76 added the 🪲 bug Something isn't working label Dec 5, 2020
jscastro76 added a commit that referenced this issue Dec 6, 2020
@jscastro76
- three.js draw geojson #125
af6b29d 
- add options.rotate and options.scale for Objects3D #126
- Create a new example with Three.js extrusions based on standard geoJson #127 Added a new example [17-extrusions.html](https://github.com/jscastro76/threebox/blob/master/examples/17-extrusions.html)
- Convert internal variables (`selectedObject`, `draggedObject`, ...) into instance variables #130
- Deprecate `tb.setLayerZoomVisibility`, overlaps with `tb.toggleLayer` #134
- when an object is wireframed, all its clones are too #124
- Error when wireframing all the objects #131
- While dragging an object if mouse overs a label it stops dragging #132
- A layer shouldn't be shown explicitely if it's not in the right zoom range #133
jscastro76 added a commit that referenced this issue Dec 9, 2020
@jscastro76
## 2.1.2
42ac721 
Minor version by [@jscastro76](https://github.com/jscastro76), some enhancements and bugs.

#### ✨ Enhancements

- #125 three.js draw geojson.
- #126 add options.rotate and options.scale for Objects3D.
- #127 Create a new example with Three.js extrusions based on standard geoJson. Added a new example [17-extrusions.html](https://github.com/jscastro76/threebox/blob/master/examples/17-extrusions.html)
- #130 Convert internal variables (`selectedObject`, `draggedObject`, ...) into instance variables .
- #134 Deprecate `tb.setLayerZoomVisibility`, overlaps with `tb.toggleLayer`.
- #138 expose `SunCalc.toJulian`

#### 🪲 Bug fixes

- #124 when an object is wireframed, all its clones are too.
- #131 Error when wireframing all the objects.
- #132 While dragging an object if mouse overs a label it stops dragging.
- #133 A layer shouldn't be shown explicitely if it's not in the right zoom range.
@jscastro76 jscastro76 mentioned this issue Feb 5, 2021
Closed
jscastro76 added a commit that referenced this issue Feb 5, 2021
@jscastro76
- #199 [.WebGL-00000210783663D0] GL_INVALID_VALUE: Invalid width.
91e49c4 
- #200 Bug in 11-animation.html example
- #201 Since #124 the objects wireframed and animated lost the animation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪲 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jscastro76