Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Tinymce lang sort - Part 2 #44000

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Conversation

tecpromotion
Copy link
Contributor

Summary of Changes

I assume that the initial PR #43910 was against 5.1-dev @brianteeman?
In 5.2, two further strings are not sorted correctly.

Testing Instructions

code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I am happy with this PR. The problem arises because some sorts put _ at the beginning and some put it at the end

@HLeithner HLeithner added the bug label Sep 2, 2024
@Hackwar Hackwar enabled auto-merge (squash) September 11, 2024 16:16
@Hackwar
Copy link
Member

Hackwar commented Sep 11, 2024

Merged after code review. Thank you @tecpromotion!

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 11, 2024
@Hackwar Hackwar merged commit fdaaaa3 into joomla:5.2-dev Sep 11, 2024
3 checks passed
@tecpromotion tecpromotion deleted the tinylang-2 branch September 17, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants