Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Upmerge 2024-07-09 #43760

Merged
merged 35 commits into from
Jul 9, 2024
Merged

Conversation

pe7er
Copy link
Contributor

@pe7er pe7er commented Jul 9, 2024

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

muhme and others added 30 commits June 17, 2024 09:07
…#43656)

- fixes issue joomla#43620 - if no 'rm' command is available on Windows
- fixes issue joomla#43622 - if cmsPath is set
- custom task 'deleteFolder' can also delete a file and ignores
  if the file does not exist -> exactly what we need
- once PR is merged i will create the next PR to rename 'deleteFolder' as 'deleteRelativePath'
  and also 'writeFile' as 'writeRelativeFile' to better represent the functions
* cy-checkin

* cs

* less

* cs

* Update tests/System/integration/administrator/components/com_checkin/Default.cy.js

Co-authored-by: Brian Teeman <[email protected]>

* Update tests/System/integration/administrator/components/com_checkin/Default.cy.js

Co-authored-by: Brian Teeman <[email protected]>

---------

Co-authored-by: Brian Teeman <[email protected]>
* cy.cache

* Update tests/System/integration/administrator/components/com_cache/Default.cy.js

Co-authored-by: Heiko Lübbe <[email protected]>

* 4.4-only

---------

Co-authored-by: Heiko Lübbe <[email protected]>
Co-authored-by: Allon Moritz <[email protected]>
* [cypress] Rename deleteFolder to clarify function

- rename deleteFolder > deleteRelativePath
  - to respect the custom task also deletes files and it does it relative to cmsPath
- rename writeFile > writeRelativeFile
  - to unify task naming and to clarify it write relative to cmsPath
- additinal:
  - small comment enhancements
  - using const name 'path' from require('path');

- no functionality is changed, only method name, variable name and comment changes
- this is a follow-up to PR joomla#43656
- tested on branch dev-4.4 successfully

* Change to writeRelativeFile in 2 samples too
* cy.mails

* Update tests/System/integration/administrator/components/com_mails/Templates.cy.js

Co-authored-by: Brian Teeman <[email protected]>

---------

Co-authored-by: Brian Teeman <[email protected]>
…43492)

* Fail in case of SMTP problems with a clear message

If the array `mail[]` is empty width length 0, the line
	`cy.wrap(mails).should('have.lengthOf', 1);`
does not cause the test to stop in this case as the Cypress
assertion inside the `.then()` has an asynchronous nature.
The effect is that the test run continues and the following access
to the mail fails with with a somehow incomprehensible message e.g.
	`TypeError: Cannot read properties of undefined (reading 'body')`

Replaced it with an `expect` statement, which immediately triggers an error,
and added an individual message that the SNMP configuration may need to be checked.

Added two more places.

* Remove custom failure msg from mail cnt assertion

* Update tests/System/integration/administrator/components/com_config/Application.cy.js

---------

Co-authored-by: Allon Moritz <[email protected]>
* Do real login test

* more tests

* cs

* Clear the session

* cs
* cy-actionlogs

* cs

* cs

* test

* test

* noresult

* cs

* simplify

* cs

* Update tests/System/integration/administrator/components/com_actionlogs/Actionlogs.cy.js

Co-authored-by: Allon Moritz <[email protected]>

* Update tests/System/integration/administrator/components/com_actionlogs/Actionlogs.cy.js

Co-authored-by: Allon Moritz <[email protected]>

* desc

* enabled-as-default

---------

Co-authored-by: Allon Moritz <[email protected]>
* [4.4] Move the Cypress Tests to ESM

* drone  signature

* resolve conflicts with joomla#43663 - part 2

* Fix path.join

* Fix path.join - 2

* Fix import join from path

* Remove the forgotten commented out orginial imports from plugin/index.js

---------

Co-authored-by: Allon Moritz <[email protected]>
* [cypress] Update doc for cypress.config.[dist].mjs

After PR joomla#43676 '[4.4] Move the Cypress Tests to ESM' the cypress config file is renamed to `.mjs`.
This PR is for updating README and architecture pictures.

* Update Code sample defaultCommandTimeout

Update with Cypress defineConfig() syntax for new ESM

* Explicit name cypress.config.mjs and use npm run

1. Error messages still mention `cypress.config.js`, e.g. on EADDRINUSE,
even there is only `cypress.config.mjs` exisiting:
```
Your configFile threw an error from: cypress.config.js
```

This is avoided for `npm run cypress` by explicitly specifying the name `cypress.config.mjs`.

2. As this does not work for `npx cypress`, all given commands are changed to use `npm run cypress`.
* [4.4] Update file lists for cypress.config*.mjs

With PR joomla#43676 '[4.4] Move the Cypress Tests to ESM' the Cypress config file is changed to `cypress.config.mjs`.
There are places in source code tree with the old file names `*.js`, that are handled by:
1. In the script used to build Joomla distribution archive packages, in the ignore file list, the Cypress config file name has been changed to the new `.mjs`.
2. In the delete-file-that-should-not-exist list, `cypress.config.mjs`and `cypress.config.dist.mjs` have been added.

* Fix typo

* Reverted script.php add-ons

See Conversation joomla#43703 (comment)
* Set permission for add-module-to-dashboard button

* more precise access check

* fix access for administrateo

---------
* Language update

* Language update

* Language update

* Language update

---------
…oomla#43734)

* Change redirect url (from headers['Location']) from array to string
* Update SocketTransport.php
Co-authored-by: Benjamin Trenkle <[email protected]>
Co-authored-by: Harald Leithner <[email protected]>
Co-authored-by: Stefan Wendhausen <[email protected]>
@pe7er pe7er requested review from laoneo and rdeutz as code owners July 9, 2024 08:32
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Jul 9, 2024
@pe7er pe7er enabled auto-merge July 9, 2024 08:33
@pe7er pe7er disabled auto-merge July 9, 2024 08:34
@pe7er
Copy link
Contributor Author

pe7er commented Jul 9, 2024

Thanks @LadySolveig for the .drone.yml fix!

@pe7er pe7er enabled auto-merge July 9, 2024 10:52
@pe7er pe7er disabled auto-merge July 9, 2024 11:45
@bembelimen bembelimen merged commit dd397e5 into joomla:5.2-dev Jul 9, 2024
3 checks passed
@bembelimen bembelimen added this to the Joomla! 5.2.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev Unit/System Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.