Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Content Category Save to Menu #43840

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

brianteeman
Copy link
Contributor

Summary of Changes

This PR adds two new menu items to the save dropdown menu on the toollbar allowing you to save a categorey directly to a menu item - either as a blog or a list just as you can directly save an article to a menu item.

This is currently restricted to categories in the com_content component. It could be expanded to other components but I didn't see the use case

Testing Instructions

Check that there are two new items in the save group as shown only for categories in com_content and not other places that categories are used such as banners and contacts

image

Check that both new items work as expected and create blog or list menu items as shown for both new and existing categories

Save to Menu as List

image

Save to Menu as Blog

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

This PR adds two new menu items to the save dropdown menu on the toollbar allowing you to save a categorey directly to a menu item - either as a blog or a list just as you can directly save an article to a menu item.

This is currently restricted to categories in the com_content component. It could be expanded to other components but I didn't see the use case

Signed-off-by: BrianTeeman <[email protected]>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Jul 24, 2024
@brianteeman brianteeman marked this pull request as ready for review July 24, 2024 12:06
@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on b38b05d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 224214d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.

@rdeutz
Copy link
Contributor

rdeutz commented Jul 25, 2024

Is the menu text not a bit imprecise. We have "Save & Close" what does what it says, but the "Save to Menu as List" is more Save & Close & Add List Menu Item. I know it is a bit long but maybe someoen else has a better idea. And yes I know it is the same for article.

@brianteeman
Copy link
Contributor Author

@rdeutz Beyond the scope of this pr for the reasons you stated. If German needs to be - more explicit then it can be done in the translation.

@PhocaCz
Copy link
Contributor

PhocaCz commented Jul 25, 2024

I think @rdeutz point of view is important. It is not so much about the language as about the logic of expression. Moreover, we must realize that English is not only English, but also the base language from which other languages ​​are based.

if I am to understand this feature, then I understand it in the case of:

Save & Close & Add List Menu Item

but I have no idea what it is about in the case of:

Save to Menu as List

And please take this as my personal opinion, I understand it as some kind of moving the article to some other group.

@LadySolveig
Copy link
Contributor

@rdeutz A completely different idea might even be to open it in a dialog. I find this sudden context switch somehow confusing. But maybe it's just me. But this is really out of scope of this PR. 🙂

@rdeutz
Copy link
Contributor

rdeutz commented Jul 25, 2024

@LadySolveig I was confused too, so we are two :-)

@brianteeman
Copy link
Contributor Author

It is still out of scope of this PR as it is NOT a new behaviour. In fact Save to menu was added 5 years ago as a result of a survey in the german community to replace an existing toolbar button called new menu item

@PhocaCz
Copy link
Contributor

PhocaCz commented Jul 25, 2024

It is still out of scope of this PR as it is NOT a new behaviour. In fact Save to menu was added 5 years ago as a result of a survey in the german community to replace an existing toolbar button called new menu item

Thanks for the explanation, I understand now, sorry, my ignorance of this feature.

@exlemor
Copy link

exlemor commented Jul 25, 2024

I have tested this item ✅ successfully on 224214d

I have tested this successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.

@brianteeman
Copy link
Contributor Author

This has three successful tests - what do I need to do to get the status changed to RTC?

@Quy
Copy link
Contributor

Quy commented Jul 26, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 26, 2024
@Hackwar
Copy link
Member

Hackwar commented Jul 26, 2024

You might just want to give us some time. I do have an eye on this PR. But please also keep in mind that right now if we follow our own rules, we can basically only merge about one PR per hour and I'm not working on Joomla 24/7, so it might take a day or two to process this.

@brianteeman
Copy link
Contributor Author

i was not chasing a merge just RTC so that others didnt waste their time on this one and tested something else

@Hackwar Hackwar enabled auto-merge (squash) July 29, 2024 14:18
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Jul 29, 2024
@Hackwar
Copy link
Member

Hackwar commented Jul 29, 2024

Thank you for your contribution @brianteeman! For now this is okay like this, in a future PR I would like to see this not restricted to just com_content, but to extend this to other components as well and make it a bit more flexible.

@brianteeman
Copy link
Contributor Author

brianteeman commented Jul 29, 2024

Thank you for your contribution @brianteeman! For now this is okay like this, in a future PR I would like to see this not restricted to just com_content, but to extend this to other components as well and make it a bit more flexible.

Thanks @Hackwar

It is not restricted to com_content as such it is just specific to com_content. It can be added to the two other core components that have a category view (newsfeeds and contacts) where it is even simpler as they only have a list view. I can submit a new PR if you wish for those components

@Hackwar
Copy link
Member

Hackwar commented Jul 29, 2024

I'd like to have a mechanism which allows also third party extensions which use com_categories to also use this.

@brianteeman
Copy link
Contributor Author

I'd like to have a mechanism which allows also third party extensions which use com_categories to also use this.

Ah sorry - I misunderstood you. I think that's an easy fix to do - I will look at it once this has been merged

@Hackwar Hackwar merged commit ab8d4ff into joomla:5.2-dev Jul 29, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 29, 2024
@brianteeman brianteeman deleted the save_categoery_menu branch July 29, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants