-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Content Category Save to Menu #43840
Conversation
This PR adds two new menu items to the save dropdown menu on the toollbar allowing you to save a categorey directly to a menu item - either as a blog or a list just as you can directly save an article to a menu item. This is currently restricted to categories in the com_content component. It could be expanded to other components but I didn't see the use case Signed-off-by: BrianTeeman <[email protected]>
Signed-off-by: BrianTeeman <[email protected]>
I have tested this item ✅ successfully on b38b05d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840. |
administrator/components/com_categories/src/View/Category/HtmlView.php
Outdated
Show resolved
Hide resolved
administrator/components/com_categories/src/View/Category/HtmlView.php
Outdated
Show resolved
Hide resolved
Signed-off-by: BrianTeeman <[email protected]>
I have tested this item ✅ successfully on 224214d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840. |
Is the menu text not a bit imprecise. We have "Save & Close" what does what it says, but the "Save to Menu as List" is more Save & Close & Add List Menu Item. I know it is a bit long but maybe someoen else has a better idea. And yes I know it is the same for article. |
@rdeutz Beyond the scope of this pr for the reasons you stated. If German needs to be - more explicit then it can be done in the translation. |
I think @rdeutz point of view is important. It is not so much about the language as about the logic of expression. Moreover, we must realize that English is not only English, but also the base language from which other languages are based. if I am to understand this feature, then I understand it in the case of: Save & Close & Add List Menu Item but I have no idea what it is about in the case of: Save to Menu as List And please take this as my personal opinion, I understand it as some kind of moving the article to some other group. |
@rdeutz A completely different idea might even be to open it in a dialog. I find this sudden context switch somehow confusing. But maybe it's just me. But this is really out of scope of this PR. 🙂 |
@LadySolveig I was confused too, so we are two :-) |
It is still out of scope of this PR as it is NOT a new behaviour. In fact Save to menu was added 5 years ago as a result of a survey in the german community to replace an existing toolbar button called new menu item |
Thanks for the explanation, I understand now, sorry, my ignorance of this feature. |
I have tested this item ✅ successfully on 224214d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840. |
This has three successful tests - what do I need to do to get the status changed to RTC? |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43840. |
You might just want to give us some time. I do have an eye on this PR. But please also keep in mind that right now if we follow our own rules, we can basically only merge about one PR per hour and I'm not working on Joomla 24/7, so it might take a day or two to process this. |
i was not chasing a merge just RTC so that others didnt waste their time on this one and tested something else |
Thank you for your contribution @brianteeman! For now this is okay like this, in a future PR I would like to see this not restricted to just com_content, but to extend this to other components as well and make it a bit more flexible. |
Thanks @Hackwar It is not restricted to com_content as such it is just specific to com_content. It can be added to the two other core components that have a category view (newsfeeds and contacts) where it is even simpler as they only have a list view. I can submit a new PR if you wish for those components |
I'd like to have a mechanism which allows also third party extensions which use com_categories to also use this. |
Ah sorry - I misunderstood you. I think that's an easy fix to do - I will look at it once this has been merged |
joomla/joomla-cms#43232 + joomla/joomla-cms#43378 + joomla/joomla-cms#43216 + joomla/joomla-cms#43260 + joomla/joomla-cms#43386 + joomla/joomla-cms#43575 + joomla/joomla-cms#43491 + joomla/joomla-cms#43760 - (upmerge, внесено в 5.1х) joomla/joomla-cms#43247 + joomla/joomla-cms#43579 + joomla/joomla-cms#43690 + joomla/joomla-cms#43829 + joomla/joomla-cms#43840 + joomla/joomla-cms#43841 + joomla/joomla-cms#43885 - (upmerge, только для др. пакетов) joomla/joomla-cms#43223 + joomla/joomla-cms#43810 - (только для en-GB) joomla/joomla-cms#43898 + joomla/joomla-cms#43432 + joomla/joomla-cms#43870 + joomla/joomla-cms#42850 + joomla/joomla-cms#43937 - (upmerge, только для др. пакетов) joomla/joomla-cms#43862 + joomla/joomla-cms#43975 + joomla/joomla-cms#43910 + joomla/joomla-cms#43965 + joomla/joomla-cms#43738 + joomla/joomla-cms#43814 + joomla/joomla-cms#44000 + joomla/joomla-cms#44050 + (upmerge, с 4.4.9) joomla/joomla-cms#43966 + joomla/joomla-cms#44065 +
Summary of Changes
This PR adds two new menu items to the save dropdown menu on the toollbar allowing you to save a categorey directly to a menu item - either as a blog or a list just as you can directly save an article to a menu item.
This is currently restricted to categories in the com_content component. It could be expanded to other components but I didn't see the use case
Testing Instructions
Check that there are two new items in the save group as shown only for categories in com_content and not other places that categories are used such as banners and contacts
Check that both new items work as expected and create blog or list menu items as shown for both new and existing categories
Save to Menu as List
Save to Menu as Blog
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed