Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

The app crashes because of new "Delete" selector which is added in 7.3 #1663

Closed
halavins opened this issue Jun 9, 2016 · 8 comments
Closed

Comments

@halavins
Copy link

halavins commented Jun 9, 2016

When I select a text in my textInputView it offers me a new button I've never seen there before: "Delete".

If I press that button, the app crashes. Yesterday my app reported 1200 crashes because of this issue.

screenshot 2016-06-09 17 33 17

2016-06-09 17:28:13.324 Secret Messenger[30587:7334460] -[JSQMessagesComposerTextView delete:]: unrecognized selector sent to instance 0x7a269800 2016-06-09 17:28:13.326 Secret Messenger[30587:7334460] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[JSQMessagesComposerTextView delete:]: unrecognized selector sent to instance 0x7a269800' *** First throw call stack: ( 0 CoreFoundation 0x04545946 __exceptionPreprocess + 182 1 libobjc.A.dylib 0x03d57a97 objc_exception_throw + 44 2 CoreFoundation 0x0454d5c5 -[NSObject(NSObject) doesNotRecognizeSelector:] + 277 3 CoreFoundation 0x044963e7 ___forwarding___ + 1047 4 CoreFoundation 0x04495fae _CF_forwarding_prep_0 + 14 5 libobjc.A.dylib 0x03d6d771 -[NSObject performSelector:withObject:] + 70 6 UIKit 0x02ebdc33 -[UICalloutBar buttonPressed:] + 355 7 libobjc.A.dylib 0x03d6d771 -[NSObject performSelector:withObject:] + 70 8 UIKit 0x02ebc39a -[UICalloutBarButton fadeAndSendAction] + 91 9 Foundation 0x01a1ab57 __NSFireDelayedPerform + 423 10 CoreFoundation 0x0449f8d6 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ + 22 11 CoreFoundation 0x0449f25d __CFRunLoopDoTimer + 1309 12 CoreFoundation 0x0445e6ba __CFRunLoopRun + 2090 13 CoreFoundation 0x0445dbcb CFRunLoopRunSpecific + 443 14 CoreFoundation 0x0445d9fb CFRunLoopRunInMode + 123 15 GraphicsServices 0x05f3924f GSEventRunModal + 192 16 GraphicsServices 0x05f3908c GSEventRun + 104 17 UIKit 0x02a308b6 UIApplicationMain + 1526 18 Secret Messenger 0x0011b708 main + 136 19 libdyld.dylib 0x0521aac9 start + 1 ) libc++abi.dylib: terminating with uncaught exception of type NSException

@halavins
Copy link
Author

halavins commented Jun 9, 2016

The auto-correction stopped working:

screenshot 2016-06-09 17 37 23

If my users make mistakes and then press the correct word, it does not work. Nothing actually happens.

My app is written on Swift. I have the last version of JSQ and it is integrated through CocoaPods.

@jessesquires
Copy link
Owner

Thanks for reporting @halvini !

We'll get on this 👍

/cc: @eliburke @GianniCarlo @MacMeDan, just FYI if anyone would like to help

@jessesquires jessesquires added this to the 7.3.3 milestone Jun 9, 2016
@jessesquires
Copy link
Owner

Bug was introduced by #1281

@halavins
Copy link
Author

halavins commented Jun 9, 2016

There is one more issue in 7.3.1.

When my users chat and receive push-notifications from other apps, if they press them it also leads to crashes.

Unfortunately, I could not reproduce that on iPhone 6 iOS 9.3, but on iPhone 5 iOS 8.3 it definitely crashes.

@halavins
Copy link
Author

halavins commented Jun 9, 2016

I am actually about to revert to 7.2, as 7.3 first lead to many crashes on iOS 7, then these crashes....

I haven't had so many crashes since the launch of my app.

@GianniCarlo
Copy link
Contributor

@jessesquires I found a quick solution to the delete crash, already created pull request. The other issue listed here about the spell check suggestion pressed not changing the text I haven't had time to check it out.

@GianniCarlo
Copy link
Contributor

oh damn, I forgot to ignore my pods in swift x.x I'll fix that pull request ASAP

@GianniCarlo
Copy link
Contributor

pull request fixed

jessesquires pushed a commit that referenced this issue Jun 10, 2016
Slessi pushed a commit to preeo/JSQMessagesViewController that referenced this issue Aug 22, 2016
Luke47 pushed a commit to ubergrape/JSQMessagesViewController that referenced this issue Jan 30, 2017
pcoltau added a commit to TeletronicsDotAe/JSQMessagesViewController that referenced this issue Apr 16, 2017
…iewController

* 'master' of https://github.com/jessesquires/JSQMessagesViewController: (86 commits)
  ImageOptim on assets (jessesquires#1845)
  update changelog and spec for 7.3.4
  Fix issue jessesquires#1583: Don't highlight cell outside message bubble (when long press) (jessesquires#1744)
  update changelog and version for 7.3.3
  Updated `canPerformAction:withSender:` in `JSQMessagesComposerTextView` to call super (jessesquires#1664). Fixes jessesquires#1663.
  Update CHANGELOG and version nums for 7.3.2
  fix KVO crash. close jessesquires#1631
  formatting
  small fix regarding scrollToIndexPath (jessesquires#1642) close jessesquires#1640
  Update CHANGELOG.md
  update CHANGLOG. bump version numbers
  Reverted jessesquires#1588 to fix jessesquires#1602 and fix jessesquires#1604. (jessesquires#1623)
  bump version numbers
  Update CHANGELOG.md
  provide default init values for JSQMessagesCollectionViewLayoutAttributes to prevent assertion. fix jessesquires#1338
  follow up for jessesquires#1247 and jessesquires#1591. obfuscate private APIs. swizzle via +initialize
  copy attributes
  clean up
  fix keyboard hiding bug on iOS 9 (jessesquires#1307). fix jessesquires#1063
  - cleanup from PR jessesquires#1281 - fix menu actions, close jessesquires#1321 - make notification methods public - partially apply changes from PR jessesquires#1563
  ...
pcoltau added a commit to TeletronicsDotAe/JSQMessagesViewController that referenced this issue Apr 16, 2017
…nch3

* origin/master: (66 commits)
  ImageOptim on assets (jessesquires#1845)
  update changelog and spec for 7.3.4
  Fix issue jessesquires#1583: Don't highlight cell outside message bubble (when long press) (jessesquires#1744)
  update changelog and version for 7.3.3
  Updated `canPerformAction:withSender:` in `JSQMessagesComposerTextView` to call super (jessesquires#1664). Fixes jessesquires#1663.
  Update CHANGELOG and version nums for 7.3.2
  fix KVO crash. close jessesquires#1631
  formatting
  small fix regarding scrollToIndexPath (jessesquires#1642) close jessesquires#1640
  Update CHANGELOG.md
  update CHANGLOG. bump version numbers
  Reverted jessesquires#1588 to fix jessesquires#1602 and fix jessesquires#1604. (jessesquires#1623)
  bump version numbers
  Update CHANGELOG.md
  provide default init values for JSQMessagesCollectionViewLayoutAttributes to prevent assertion. fix jessesquires#1338
  follow up for jessesquires#1247 and jessesquires#1591. obfuscate private APIs. swizzle via +initialize
  copy attributes
  clean up
  fix keyboard hiding bug on iOS 9 (jessesquires#1307). fix jessesquires#1063
  - cleanup from PR jessesquires#1281 - fix menu actions, close jessesquires#1321 - make notification methods public - partially apply changes from PR jessesquires#1563
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants