Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

Crash on iOS 7 after updating to 7.3.0 #1604

Closed
nickdowell opened this issue May 27, 2016 · 2 comments
Closed

Crash on iOS 7 after updating to 7.3.0 #1604

nickdowell opened this issue May 27, 2016 · 2 comments
Labels
bug priority: high
Milestone
7.3.1

Comments

@nickdowell
Copy link

After updating from version 7.2.0 to 7.3.0 of this project, a crash occurs on iOS 7 when a non-empty message view controller is pushed. This issue was never seen in version 7.2.0 or on iOS 9 with the latest version.

The crash is due to infinite recursion;

Crashed: com.apple.main-thread
0   Foundation                     0x2e8d6c90 -[NSISEngine _flushPendingRemovals] + 27
1   Foundation                     0x2e8d6b5d -[NSISEngine withBehaviors:performModifications:] + 260
2   Foundation                     0x2e8d6b5d -[NSISEngine withBehaviors:performModifications:] + 260
3   UIKit                          0x3088088b -[UIView(AdditionalLayoutSupport) updateConstraintsIfNeeded] + 170
4   UIKit                          0x307a1db3 -[UIView(Hierarchy) layoutBelowIfNeeded] + 334
5   Super App                      0x205167 -[JSQMessagesViewController jsq_setToolbarBottomLayoutGuideConstant:] (JSQMessagesViewController.m:928)
6   Super App                      0x2025ed -[JSQMessagesViewController viewWillLayoutSubviews] (JSQMessagesViewController.m:311)
7   UIKit                          0x3078cd17 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 314
8   QuartzCore                     0x3040a62b -[CALayer layoutSublayers] + 142
9   QuartzCore                     0x30405e3b CA::Layer::layout_if_needed(CA::Transaction*) + 350
10  UIKit                          0x307a1e8b -[UIView(Hierarchy) layoutBelowIfNeeded] + 550
11  Super App                      0x205167 -[JSQMessagesViewController jsq_setToolbarBottomLayoutGuideConstant:] (JSQMessagesViewController.m:928)
12  Super App                      0x2025ed -[JSQMessagesViewController viewWillLayoutSubviews] (JSQMessagesViewController.m:311)
13  UIKit                          0x3078cd17 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 314
14  QuartzCore                     0x3040a62b -[CALayer layoutSublayers] + 142
15  QuartzCore                     0x30405e3b CA::Layer::layout_if_needed(CA::Transaction*) + 350
16  UIKit                          0x307a1e8b -[UIView(Hierarchy) layoutBelowIfNeeded] + 550
17  Super App                      0x205167 -[JSQMessagesViewController jsq_setToolbarBottomLayoutGuideConstant:] (JSQMessagesViewController.m:928)
18  Super App                      0x2025ed -[JSQMessagesViewController viewWillLayoutSubviews] (JSQMessagesViewController.m:311)
19  UIKit                          0x3078cd17 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 314
20  QuartzCore                     0x3040a62b -[CALayer layoutSublayers] + 142
21  QuartzCore                     0x30405e3b CA::Layer::layout_if_needed(CA::Transaction*) + 350
22  UIKit                          0x307a1e8b -[UIView(Hierarchy) layoutBelowIfNeeded] + 550
23  Super App                      0x205167 -[JSQMessagesViewController jsq_setToolbarBottomLayoutGuideConstant:] (JSQMessagesViewController.m:928)
24  Super App                      0x2025ed -[JSQMessagesViewController viewWillLayoutSubviews] (JSQMessagesViewController.m:311)
25  UIKit                          0x3078cd17 -[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 314
26  QuartzCore                     0x3040a62b -[CALayer layoutSublayers] + 142
27  QuartzCore                     0x30405e3b CA::Layer::layout_if_needed(CA::Transaction*) + 350
28  UIKit                          0x307a1e8b -[UIView(Hierarchy) layoutBelowIfNeeded] + 550
29  Super App                      0x205167 -[JSQMessagesViewController jsq_setToolbarBottomLayoutGuideConstant:] (JSQMessagesViewController.m:928)
30  Super App                      0x2025ed -[JSQMessagesViewController viewWillLayoutSubviews] (JSQMessagesViewController.m:311)
@jessesquires jessesquires modified the milestone: 7.3.1 May 27, 2016
@jessesquires
Copy link
Owner

Thanks @nixxcode !

We need to revert #1588

sebastianludwig added a commit to sebastianludwig/JSQMessagesViewController that referenced this issue May 29, 2016
@sebastianludwig
Reverted jessesquires#1588 to fix jessesquires#1602 and jessesquires#…
71c2256 
…1604.
@sebastianludwig sebastianludwig mentioned this issue May 29, 2016
Closed
7 tasks
sebastianludwig added a commit to sebastianludwig/JSQMessagesViewController that referenced this issue May 30, 2016
@sebastianludwig
Reverted jessesquires#1588 to fix jessesquires#1602 and jessesquires#…
a0e49ee 
…1604.
This was referenced May 30, 2016
Closed
Merged
jessesquires pushed a commit that referenced this issue May 30, 2016
@sebastianludwig @jessesquires
Reverted #1588 to fix #1602 and fix #1604. (#1623)
d099c56
@jessesquires
Copy link
Owner

fixed by #1623

Slessi pushed a commit to preeo/JSQMessagesViewController that referenced this issue Aug 22, 2016
@sebastianludwig
Reverted jessesquires#1588 to fix jessesquires#1602 and fix jessesqui…
7d494a3 
…res#1604. (jessesquires#1623)
pcoltau added a commit to TeletronicsDotAe/JSQMessagesViewController that referenced this issue Apr 16, 2017
@pcoltau
Merge branch 'master' of https://github.com/jessesquires/JSQMessagesV…
c3282c8 
…iewController

* 'master' of https://github.com/jessesquires/JSQMessagesViewController: (86 commits)
  ImageOptim on assets (jessesquires#1845)
  update changelog and spec for 7.3.4
  Fix issue jessesquires#1583: Don't highlight cell outside message bubble (when long press) (jessesquires#1744)
  update changelog and version for 7.3.3
  Updated `canPerformAction:withSender:` in `JSQMessagesComposerTextView` to call super (jessesquires#1664). Fixes jessesquires#1663.
  Update CHANGELOG and version nums for 7.3.2
  fix KVO crash. close jessesquires#1631
  formatting
  small fix regarding scrollToIndexPath (jessesquires#1642) close jessesquires#1640
  Update CHANGELOG.md
  update CHANGLOG. bump version numbers
  Reverted jessesquires#1588 to fix jessesquires#1602 and fix jessesquires#1604. (jessesquires#1623)
  bump version numbers
  Update CHANGELOG.md
  provide default init values for JSQMessagesCollectionViewLayoutAttributes to prevent assertion. fix jessesquires#1338
  follow up for jessesquires#1247 and jessesquires#1591. obfuscate private APIs. swizzle via +initialize
  copy attributes
  clean up
  fix keyboard hiding bug on iOS 9 (jessesquires#1307). fix jessesquires#1063
  - cleanup from PR jessesquires#1281 - fix menu actions, close jessesquires#1321 - make notification methods public - partially apply changes from PR jessesquires#1563
  ...
pcoltau added a commit to TeletronicsDotAe/JSQMessagesViewController that referenced this issue Apr 16, 2017
@pcoltau
Merge remote-tracking branch 'origin/master' into tlt-integration-bra…
bc3e430 
…nch3

* origin/master: (66 commits)
  ImageOptim on assets (jessesquires#1845)
  update changelog and spec for 7.3.4
  Fix issue jessesquires#1583: Don't highlight cell outside message bubble (when long press) (jessesquires#1744)
  update changelog and version for 7.3.3
  Updated `canPerformAction:withSender:` in `JSQMessagesComposerTextView` to call super (jessesquires#1664). Fixes jessesquires#1663.
  Update CHANGELOG and version nums for 7.3.2
  fix KVO crash. close jessesquires#1631
  formatting
  small fix regarding scrollToIndexPath (jessesquires#1642) close jessesquires#1640
  Update CHANGELOG.md
  update CHANGLOG. bump version numbers
  Reverted jessesquires#1588 to fix jessesquires#1602 and fix jessesquires#1604. (jessesquires#1623)
  bump version numbers
  Update CHANGELOG.md
  provide default init values for JSQMessagesCollectionViewLayoutAttributes to prevent assertion. fix jessesquires#1338
  follow up for jessesquires#1247 and jessesquires#1591. obfuscate private APIs. swizzle via +initialize
  copy attributes
  clean up
  fix keyboard hiding bug on iOS 9 (jessesquires#1307). fix jessesquires#1063
  - cleanup from PR jessesquires#1281 - fix menu actions, close jessesquires#1321 - make notification methods public - partially apply changes from PR jessesquires#1563
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug priority: high
Projects
None yet
Milestone
7.3.1
Development

No branches or pull requests
2 participants
@nickdowell @jessesquires