feat: [JENKINS-66699] Exchange default PNGs with SVG icons

[NotMyFault]

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

This PR aims to replace the PNGs with SVGs to present a more modern looking-like appearance.
Addresses https://issues.jenkins.io/browse/JENKINS-66699

Before:

After:

[jglick]

SVG renames seem good. AFAICT there should be no new SVGs in this PR, because we should be picking them up from core sooner or later.

I suppose src/main/webapp/images/make-inkscape.sh should not get bundled in the binary.

@timja @uhafner @oleg-nenashev as reviewers of jenkinsci/jenkins#5663

[timja]

I suppose src/main/webapp/images/make-inkscape.sh should not get bundled in the binary.

I think we removed the script from jenkinsci/jenkins as part of the original PR, it can probably be removed from here too?

[NotMyFault]

I suppose src/main/webapp/images/make-inkscape.sh should not get bundled in the binary.

I think we removed the script from jenkinsci/jenkins as part of the original PR, it can probably be removed from here too?

I've removed it for now and removed the added svgs in favor of increasing the minimum version to 2.308.

[timja]

You need to update jenkins.version in pom.xml for that

[jglick]

Diff looks good. Needs an outside sanity check. Not sure who the plugin maintainer here is.

[timja]

generally @jvz, but also @daniel-beck and @Wadeck by the looks of it

[oleg-nenashev]

Looks good to me. Will need an upgrade guide entry in the Jenkins core

[oleg-nenashev]

I'm not sure I am still a maintainer. IIRC @daniel-beck has cleaned up my name at some point. Otherwise can release it

[timja]

Looks good to me. Will need an upgrade guide entry in the Jenkins core

Probably overkill? If users don't do this they will see what they had before. When they upgrade they will get sharper icons. (but it can be done)

[Wadeck]

Except the user credentials icon, the SVGs are better, especially at higher level of zoom.

Thanks for the PR @NotMyFault

Screenshots

100%, before

100%, after

200%, before

200%, after

[KalleOlaviNiemitalo]

Could you add the jenkins.version change to the Credentials 2.6.2 release notes? This change caused Credentials 2.6.2 to be unavailable for the latest Jenkins LTS 2.303.2 (2021-10-06), and it would be good to have the reason clearly visible.

[timja]

I've added it to the release notes, cc @jglick

[uhafner]

Why is that? I would suggest using 2.289.1, see https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/.

[jglick]

Because of jenkinsci/jenkins#5663.

[jglick]

In general, any plugin release may begin to require a newer version of Jenkins core. You should not normally need to pay attention to that, because the update center will only offer versions compatible with the core you are actually running; and PRs like jenkinsci/warnings-ng-plugin#1083 should not be necessary if you simply import bom (each BOM line will include only plugins compatible with the corresponding core LTS line).

[daniel-beck]

Likely caused JENKINS-68674.

[jglick]

⇒ jenkinsci/cloudbees-folder-plugin#239