-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [JENKINS-66699] Exchange default PNGs with SVG icons #230
feat: [JENKINS-66699] Exchange default PNGs with SVG icons #230
Conversation
8ec9ea9
to
2e2d03f
Compare
2e2d03f
to
5b17023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVG renames seem good. AFAICT there should be no new SVGs in this PR, because we should be picking them up from core sooner or later.
I suppose src/main/webapp/images/make-inkscape.sh
should not get bundled in the binary.
@timja @uhafner @oleg-nenashev as reviewers of jenkinsci/jenkins#5663
.../com/cloudbees/plugins/credentials/CredentialsStoreAction/CredentialsWrapper/sidepanel.jelly
Show resolved
Hide resolved
...urces/com/cloudbees/plugins/credentials/CredentialsStoreAction/DomainWrapper/sidepanel.jelly
Outdated
Show resolved
Hide resolved
I think we removed the script from jenkinsci/jenkins as part of the original PR, it can probably be removed from here too? |
8a5745d
to
c53d6d4
Compare
c53d6d4
to
0803b31
Compare
I've removed it for now and removed the added svgs in favor of increasing the minimum version to 2.308. |
You need to update |
.../com/cloudbees/plugins/credentials/CredentialsStoreAction/CredentialsWrapper/sidepanel.jelly
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff looks good. Needs an outside sanity check. Not sure who the plugin maintainer here is.
generally @jvz, but also @daniel-beck and @Wadeck by the looks of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will need an upgrade guide entry in the Jenkins core
I'm not sure I am still a maintainer. IIRC @daniel-beck has cleaned up my name at some point. Otherwise can release it |
Probably overkill? If users don't do this they will see what they had before. When they upgrade they will get sharper icons. (but it can be done) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except the user credentials icon, the SVGs are better, especially at higher level of zoom.
Thanks for the PR @NotMyFault
Could you add the |
I've added it to the release notes, cc @jglick |
@@ -67,7 +67,7 @@ | |||
<properties> | |||
<revision>2.6.2</revision> | |||
<changelist>-SNAPSHOT</changelist> | |||
<jenkins.version>2.222.4</jenkins.version> | |||
<jenkins.version>2.308</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is that? I would suggest using 2.289.1, see https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of jenkinsci/jenkins#5663.
In general, any plugin release may begin to require a newer version of Jenkins core. You should not normally need to pay attention to that, because the update center will only offer versions compatible with the core you are actually running; and PRs like jenkinsci/warnings-ng-plugin#1083 should not be necessary if you simply import |
Likely caused JENKINS-68674. |
This PR aims to replace the PNGs with SVGs to present a more modern looking-like appearance.
Addresses https://issues.jenkins.io/browse/JENKINS-66699
Before:
After: