Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump credentials from 2.6.1 to 2.6.2 #1083

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2021

Bumps credentials from 2.6.1 to 2.6.2.

Release notes

Sourced from credentials's releases.

2.6.2

🚀 New features and improvements

🐛 Bug fixes

📦 Dependency updates

👻 Maintenance

🚦 Tests

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [credentials](https://github.com/jenkinsci/credentials-plugin) from 2.6.1 to 2.6.2.
- [Release notes](https://github.com/jenkinsci/credentials-plugin/releases)
- [Changelog](https://github.com/jenkinsci/credentials-plugin/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/credentials-plugin@credentials-2.6.1...credentials-2.6.2)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:credentials
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Update of dependencies java Pull requests that update Maven Java dependencies labels Oct 25, 2021
@KalleOlaviNiemitalo
Copy link
Contributor

KalleOlaviNiemitalo commented Oct 25, 2021

Please block this for a while. I have Credentials 2.6.1 installed on the latest Jenkins LTS 2.303.2 and the update center tells me that Credentials 2.6.2 is unavailable. The Jenkins minimum version was raised to 2.308 in jenkinsci/credentials-plugin#230 but there isn't yet any Jenkins LTS release that satisfies this requirement.

@jglick
Copy link
Member

jglick commented Oct 25, 2021

Use the plugin BOM instead.

@uhafner
Copy link
Member

uhafner commented Oct 25, 2021

Use the plugin BOM instead.

Actually I am using the BOM. Seems that I forgot to remove some plugin versions that are in the BOM (or are now in the BOM since I upgraded to Jenkins BOM 2.289.1).

What also does not seem to work (or I am using it in the wrong way). The checks-api is defined in the BOM: https://github.com/jenkinsci/bom/blob/master/bom-weekly/pom.xml#L44-L54

This works for the normal dependency, but not for the test dependency:
ok: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/pom.xml#L227
nok: https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/pom.xml#L399
For the test-jar I get a maven error:

[ERROR]   The project io.jenkins.plugins:warnings-ng:9.6.0-SNAPSHOT (/Users/hafner/Development/git/warnings-ng-plugin-devenv/warnings-ng-plugin/plugin/pom.xml) has 1 error
[ERROR]     'dependencies.dependency.version' for io.jenkins.plugins:checks-api:test-jar is missing. @ io.jenkins.plugins:warnings-ng:${revision}${changelist}, /Users/hafner/Development/git/warnings-ng-plugin-devenv/warnings-ng-plugin/plugin/pom.xml, line 395, column 17

Do need to reference the test-jar differently?

@jglick
Copy link
Member

jglick commented Oct 25, 2021

Use classifier not type and it should work.

BTW always press the Y key to get a permalink before pasting a source link into a discussion, or the URL will become meaningless when the file is next edited on that line or above.

@uhafner
Copy link
Member

uhafner commented Oct 25, 2021

When I use classifier I get:

Downloading from central: https://repo1.maven.org/maven2/io/jenkins/plugins/checks-api/1.7.2/checks-api-1.7.2-test-jar.jar
Downloading from repo.jenkins-ci.org: https://repo.jenkins-ci.org/public/io/jenkins/plugins/checks-api/1.7.2/checks-api-1.7.2-test-jar.jar
Downloading from incrementals.jenkins-ci.org: https://repo.jenkins-ci.org/incrementals/io/jenkins/plugins/checks-api/1.7.2/checks-api-1.7.2-test-jar.jar
Downloading from incrementals: https://repo.jenkins-ci.org/incrementals/io/jenkins/plugins/checks-api/1.7.2/checks-api-1.7.2-test-jar.jar
[ERROR] Failed to execute goal on project warnings-ng: Could not resolve dependencies for project io.jenkins.plugins:warnings-ng:hpi:9.6.0-SNAPSHOT: Could not find artifact io.jenkins.plugins:checks-api:jar:test-jar:1.7.2 in central (https://repo1.maven.org/maven2) -> [Help 1]
[

@uhafner
Copy link
Member

uhafner commented Oct 25, 2021

Ok I found it: I must use:

<classifier>tests</classifier>

@uhafner
Copy link
Member

uhafner commented Oct 25, 2021

Superseded by #1084

I found a lot of versions that are now part of the BOM 🤦‍♂️

@uhafner uhafner closed this Oct 25, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 25, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/maven/org.jenkins-ci.plugins-credentials-2.6.2 branch October 25, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies java Pull requests that update Maven Java dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants