-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icon for folder credentials store is gone from credentials plugin #239
Conversation
Also please consider my note in Jira that the icon appears to be used only in this plugin (confirm!) so it would make sense to move it here from |
Signed-off-by: Thierry Wasylczenko <[email protected]>
Signed-off-by: Thierry Wasylczenko <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK assuming it works.
What does this mean? That it's sure the icon is only used here or does it mean I have to confirm the icon is only used here? |
Yes, I believe the icon is located in |
Signed-off-by: Thierry Wasylczenko <[email protected]>
@jglick I made the icon migration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right.
Fix released. Can you file a cleanup PR in |
Hello, I think it is not a good idea to remove this icon from credentials plugin. And after inspecting the code, we see that it is the image folder-store.svg which the credentials plugin need, that is missing Our actual configuration |
⇒ #253 |
See JENKINS-68674.
Before this PR, the icon for the folder credentials in the crumb bar was missing. Now with the change, the icon is back:
Proposed changelog entries
Submitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)