Icon for folder credentials store is gone from credentials plugin

[twasyl]

See JENKINS-68674.

Before this PR, the icon for the folder credentials in the crumb bar was missing. Now with the change, the icon is back:

Proposed changelog entries

• Entry 1: Issue, Icon for folder credentials store has been updated to match credentials plugin change

Submitter checklist

• JIRA issue is well described
• Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change).
  * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
• Appropriate autotests or explanation to why this change has no tests

[jglick]

Also please consider my note in Jira that the icon appears to be used only in this plugin (confirm!) so it would make sense to move it here from credentials, along with the icon set registration code for it.

[jglick]

Looks OK assuming it works.

[twasyl]

the icon appears to be used only in this plugin (confirm!)

What does this mean? That it's sure the icon is only used here or does it mean I have to confirm the icon is only used here?

[jglick]

does it mean I have to confirm

Yes, I believe the icon is located in credentials yet unused there (except for its registration code) and only in fact used in cloudbees-folder (there was historically some refactoring of where the folder credentials store should be kept); if you have time, you should confirm this, and if true then the cleanest approach would be move it: copy the icon here, adjust this plugin to use its own copy, release this, then go back and delete the now-unused icon from credentials.

[twasyl]

I believe the icon is located in credentials

Yes it is:

[twasyl]

@jglick I made the icon migration

[jglick]

Looks right.

[jglick]

Fix released. Can you file a cleanup PR in credentials?

[papemamadou91]

Hello,

I think it is not a good idea to remove this icon from credentials plugin.
Since, we updated our credentials plugin to their latest version, we have some icon that are missing (see picture below)

And after inspecting the code, we see that it is the image folder-store.svg which the credentials plugin need, that is missing

Our actual configuration
Jenkins : 2.346.1
Credentials plugin : 1139.veb_9579fca_33b_ (this is the latest)
Cloudbees-Folder Plugin : 6.729.v2b_9d1a_74d673 (this is the latest)

[jglick]

⇒ #253