Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Plugin Utilities API from 2.14.0 to 2.16.0 #164

Merged
merged 8 commits into from
May 5, 2022

Conversation

basil
Copy link
Member

@basil basil commented May 5, 2022

Adapting to jenkinsci/plugin-util-api-plugin#161. The motivation for this is getting jenkinsci/bom up and running with JENKINS-45047, which exposes this compatibility problem.

Monkey see, monkey do style programming (copying warnings-ng), so please don't be too hard on me. I have no idea what I am doing here, just banging around on a keyboard until the tests pass. If something doesn't make sense to you, there is probably a better way. One thing I am confident about is that each and every change in this PR is necessary to get the tests to pass, so if you think some change isn't necessary, try testing without it and see what happens.

CC @timja @uhafner

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #164 (8e06a04) into master (a3bde2f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #164   +/-   ##
=========================================
  Coverage     85.38%   85.38%           
  Complexity      152      152           
=========================================
  Files            17       17           
  Lines           746      746           
  Branches         57       57           
=========================================
  Hits            637      637           
  Misses           89       89           
  Partials         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3bde2f...8e06a04. Read the comment docs.

@basil basil marked this pull request as draft May 5, 2022 18:30
@basil
Copy link
Member Author

basil commented May 5, 2022

Please hold as I fix the style checks that were reported to me when doing a CI build but not reported to me in a local build. =\

@basil basil marked this pull request as ready for review May 5, 2022 19:18
@basil
Copy link
Member Author

basil commented May 5, 2022

Checkstyle now complains about redundant public modifiers on lines 164 and 175 of WithChecksStepITest, but I couldn't figure out how to remove the public modifiers without breaking either compilation or @TestExtension. I ran into a similar problem in core and ended up suppressing the violations in cases like this. Could the maintainers please suppress these warnings? Thanks!

@timja
Copy link
Member

timja commented May 5, 2022

FWIW I’ve hit this before :( #99

@basil
Copy link
Member Author

basil commented May 5, 2022

The build is now green.

@timja timja added the developer label May 5, 2022
@timja timja merged commit c129796 into jenkinsci:master May 5, 2022
@basil basil deleted the plugin-util-api branch May 5, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants