-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Plugin Utilities API from 2.14.0 to 2.16.0 #164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=========================================
Coverage 85.38% 85.38%
Complexity 152 152
=========================================
Files 17 17
Lines 746 746
Branches 57 57
=========================================
Hits 637 637
Misses 89 89
Partials 20 20 Continue to review full report at Codecov.
|
Please hold as I fix the style checks that were reported to me when doing a CI build but not reported to me in a local build. =\ |
Checkstyle now complains about redundant |
…ill revert momentarily" This reverts commit cc9445f.
FWIW I’ve hit this before :( #99 |
The build is now green. |
Adapting to jenkinsci/plugin-util-api-plugin#161. The motivation for this is getting
jenkinsci/bom
up and running with JENKINS-45047, which exposes this compatibility problem.Monkey see, monkey do style programming (copying
warnings-ng
), so please don't be too hard on me. I have no idea what I am doing here, just banging around on a keyboard until the tests pass. If something doesn't make sense to you, there is probably a better way. One thing I am confident about is that each and every change in this PR is necessary to get the tests to pass, so if you think some change isn't necessary, try testing without it and see what happens.CC @timja @uhafner