Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JUnit 5 for integration tests #161

Merged
merged 16 commits into from
Apr 1, 2022
Merged

Use JUnit 5 for integration tests #161

merged 16 commits into from
Apr 1, 2022

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 23, 2022

Refactor integration test base classes to use the new JUnit testing rules that have been originally provided by jenkinsci/jenkins-test-harness#375. Since the JUnit5 rules do not work within Jenkins test harness yet, this PR tries to provide these classes for plugins only. For more details, please refer to JENKINS-48466.

@uhafner uhafner added the tests Enhancement of tests label Feb 23, 2022
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uhafner Breaks compatibility with checks-api as seen in jenkinsci/checks-api-plugin#156. When checks-api is updated to include these changes, it stops compiling. This is affecting my PCT work. A PR needs to be prepared to checks-api to update it to a version of plugin-util-api that includes these changes, adapting checks-api to the breaking changes as necessary. Until this is done, I cannot proceed with JENKINS-45047.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants