-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local build doesn't fail for checkstyle or spotbugs #99
Comments
I normally never use maven locally 😄 I commit (and IntelliJ starts CheckStyle and SpotBugs Issues before the commit). That is typically enough for me. The problem with maven is that it cannot check for new issues. |
Do you have a pre commit hook that runs them? i.e how do you have it setup to run those? |
There is at least some precedent for ratcheting functionality in Spotless Maven Plugin. |
The new 8.x release of analysis-pom contains an upgrade to PMD 7 with modified rules and some additional CheckStyle rules. Maven will now correctly break the build locally if there are warnings. Fixes #99
Pretty frustrating, what is your workflow for this @uhafer?
I run
mvn clean install
and then I create a PR and it fails for spotbugs or checkstyleThe text was updated successfully, but these errors were encountered: