Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local build doesn't fail for checkstyle or spotbugs #99

Closed
timja opened this issue Apr 1, 2021 · 4 comments · Fixed by #255
Closed

Local build doesn't fail for checkstyle or spotbugs #99

timja opened this issue Apr 1, 2021 · 4 comments · Fixed by #255
Labels
bug Something isn't working

Comments

@timja
Copy link
Member

timja commented Apr 1, 2021

Pretty frustrating, what is your workflow for this @uhafer?

I run mvn clean install and then I create a PR and it fails for spotbugs or checkstyle

@timja timja added the bug Something isn't working label Apr 1, 2021
@uhafner
Copy link
Member

uhafner commented Apr 1, 2021

I normally never use maven locally 😄

I commit (and IntelliJ starts CheckStyle and SpotBugs Issues before the commit). That is typically enough for me. The problem with maven is that it cannot check for new issues.

@timja
Copy link
Member Author

timja commented Apr 1, 2021

Do you have a pre commit hook that runs them?

i.e how do you have it setup to run those?

@uhafner
Copy link
Member

uhafner commented Apr 1, 2021

I'm just using the checkstyle and spotbugs plugins:

Bildschirmfoto 2021-04-01 um 20 18 28

@basil
Copy link
Member

basil commented May 5, 2022

The problem with maven is that it cannot check for new issues.

There is at least some precedent for ratcheting functionality in Spotless Maven Plugin.

uhafner added a commit that referenced this issue May 17, 2024
The new 8.x release of analysis-pom contains an upgrade to PMD 7
with modified rules and some additional CheckStyle rules.

Maven will now correctly break the build locally if there are warnings.
Fixes #99
@uhafner uhafner linked a pull request May 17, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants