Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scrobble durations #269

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

kgarner7
Copy link
Collaborator

Something changed to the duration that makes it ms, but the song time is measured in seconds. This PR seeks to address that. (note that I am not sure if this is all of the cases, but it appears to behave in Jellyfin and Navidrome)

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 4:28am

@jeffvli
Copy link
Owner

jeffvli commented Oct 5, 2023

Fixes #269 I believe

@jeffvli jeffvli linked an issue Oct 5, 2023 that may be closed by this pull request
@avh4 avh4 mentioned this pull request Oct 6, 2023
12 tasks
@jeffvli jeffvli merged commit 6bac172 into jeffvli:development Oct 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.4.0 seems to drop 10-20% of scrobbles
2 participants