feishin: 0.3.0 -> 0.4.1

[nephalemsec]

Description of changes

Simple update to hashes for Feishin version bump.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[avh4]

I'm getting a hash mismatch on the downloaded source when I try this:

❯ nix-build -A feishin
these 2 derivations will be built:
  /nix/store/f2avlgxvai0aqn53gglxwx9zrp5bxxs6-Feishin-0.4.0-linux-x64.tar.xz.drv
  /nix/store/s080fbrv6nplv9sz1c7219rdif3jg98l-feishin-0.4.0.drv
building '/nix/store/f2avlgxvai0aqn53gglxwx9zrp5bxxs6-Feishin-0.4.0-linux-x64.tar.xz.drv'...

trying https://github.com/jeffvli/feishin/releases/download/v0.4.0/Feishin-0.4.0-linux-x64.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 68.4M  100 68.4M    0     0  8223k      0  0:00:08  0:00:08 --:--:-- 9129k
error: hash mismatch in fixed-output derivation '/nix/store/f2avlgxvai0aqn53gglxwx9zrp5bxxs6-Feishin-0.4.0-linux-x64.tar.xz.drv':
         specified: sha256-KA40AJ55s2HQLCJvS7ZRJcAjlCuELRm5DRcRVJles8s=
            got:    sha256-2S2/UA9tU3wAtOwR8P82rU/wkI4neGOgAaGrEi5NstU=
error: 1 dependencies of derivation '/nix/store/s080fbrv6nplv9sz1c7219rdif3jg98l-feishin-0.4.0.drv' failed to build

Is this just something weird with my environment, or maybe did feishin's 0.4.0 tag change since you created the PR?

[nephalemsec]

I'm getting a hash mismatch on the downloaded source when I try this:

❯ nix-build -A feishin
these 2 derivations will be built:
  /nix/store/f2avlgxvai0aqn53gglxwx9zrp5bxxs6-Feishin-0.4.0-linux-x64.tar.xz.drv
  /nix/store/s080fbrv6nplv9sz1c7219rdif3jg98l-feishin-0.4.0.drv
building '/nix/store/f2avlgxvai0aqn53gglxwx9zrp5bxxs6-Feishin-0.4.0-linux-x64.tar.xz.drv'...

trying https://github.com/jeffvli/feishin/releases/download/v0.4.0/Feishin-0.4.0-linux-x64.tar.xz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 68.4M  100 68.4M    0     0  8223k      0  0:00:08  0:00:08 --:--:-- 9129k
error: hash mismatch in fixed-output derivation '/nix/store/f2avlgxvai0aqn53gglxwx9zrp5bxxs6-Feishin-0.4.0-linux-x64.tar.xz.drv':
         specified: sha256-KA40AJ55s2HQLCJvS7ZRJcAjlCuELRm5DRcRVJles8s=
            got:    sha256-2S2/UA9tU3wAtOwR8P82rU/wkI4neGOgAaGrEi5NstU=
error: 1 dependencies of derivation '/nix/store/s080fbrv6nplv9sz1c7219rdif3jg98l-feishin-0.4.0.drv' failed to build

Is this just something weird with my environment, or maybe did feishin's 0.4.0 tag change since you created the PR?

Yeah seems to have changed. I meant to update it before i left for conference. Ultimately I'd love for the bot to come through and update tags for us 😂

[avh4]

FYI, in case it matter to you personally, there's a bug in 0.4.0 upstream that makes it not consistently submit scrobbles jeffvli/feishin#269 so I'm hoping they'll be making a new new release soon

[avh4]

Yeah, FYI upstream released 0.4.1 with some bug fixes: https://github.com/jeffvli/feishin/releases/tag/v0.4.1

[nephalemsec]

Thanks mate, I'll test and update this PR after work today 😄

[nephalemsec]

These are the hash values for anyone who doesn't want to wait for me:

  filename =
    if stdenv.isDarwin then
      "${appname}-${version}-mac-x64.zip"
    else
      "${appname}-${version}-linux-x64.tar.xz";
  src = fetchurl {
    url =
      "https://github.com/jeffvli/feishin/releases/download/v${version}/${filename}";
    sha256 =
      if stdenv.isDarwin then
        "sha256-6GYp9uzlR1eVRYhNU3kOmcUOPFY3J9eJPqN+TucNavA="
      else
        "sha256-Y8r329rO7z8V2xP/uRsjTFJfvTn+zyeAYzq6fKDxXs4=";
  };

[Artturin]

Don't use merge in PR's here, instead rebase if you have to update the branch.

There should only be one commit in this PR, use git rebase to drop the merge and fixup the commits.

[nephalemsec]

Don't use merge in PR's here, instead rebase if you have to update the branch.

There should only be one commit in this PR, use git rebase to drop the merge and fixup the commits.

Are these official instructions or your personal opinions as I don't see this in the contributing page? I just followed instructions on the contributing.md to the letter.

It states that squashing commits isn't required if they give context to an additional change.

[Artturin]

Don't use merge in PR's here, instead rebase if you have to update the branch.
There should only be one commit in this PR, use git rebase to drop the merge and fixup the commits.

Are these official instructions or your personal opinions as I don't see this in the contributing page? I just followed instructions on the contributing.md to the letter.

Not having merge commits is common PR hygiene, rebasing is cleaner when the commit hashes don't have to be preserved and there's a conflict.

It states that squashing commits isn't required if they give context to an additional change.

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

This line applies

If you have commits pkg-name: oh, forgot to insert whitespace: squash commits in this case. Use git rebase -i.

Having more than one trivial update commit to the same package in a PR is logically unnecessary.

[nephalemsec]

While I appreciate the advice I really don't think there is an overabundance of commits in here that would confuse/disorientate anyone reviewing this PR.

Feel free to make amendments yourself if you feel so inclined. All the required information for a simple version bump is there.

[Artturin]

I've done it for you, Please remember the advice for your future PRs because other reviewers will say the same.

Also fixed a deprecation warning during the desktop file build, and added a forgotten inherit meta so the package's maintainers get tagged for review.

[onny]

Result of nixpkgs-review pr 257430 run on x86_64-linux 1

1 package built:

• feishin

[onny]

Thank you both for updating!