Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last track in queue is not scrobbled #207

Closed
JortRoelofs opened this issue Aug 9, 2023 · 3 comments
Closed

Last track in queue is not scrobbled #207

JortRoelofs opened this issue Aug 9, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@JortRoelofs
Copy link

Expected Behavior

When playing a queue, consisting of an album for example, all tracks are expected to be scrobbled properly.

Current Behavior

When playing a single track or a queue, the single track or last track in the queue are not scrobbled properly most of the time. I can see in the access log of my Navidrome webserver that a scrobble request is passed to the server API with submission=false, probably to indicate the track that is currently playing. Then, whenever the next track comes on, an API call is made for the played song with submission=true to write the scrobble and a second call is made with submission=false to register the next song that is playing. However, when the last song in the queue has ended, there's (almost) never a scrobble API call made.

Steps to Reproduce

  1. Turn on scrobbling, both on Navidrom as in Feishin.
  2. Play an album or any queue of songs.
  3. Let scrobbles be registered by the application.
  4. The final song is then never scrobbled.

Possible Solution (Not obligatory)

N/A

Context

Because of this bug my scrobbles on LastFM don't get registered properly.

Your Environment

  • Application version (e.g. v0.1.0) : the bug persists both on v0.2.0 and v0.3.0
  • Operating System and version (e.g. Windows 10) : Windows 10
  • Server and version (e.g. Navidrome v0.48.0) : Navidrom v0.49.3
  • Node version (if developing locally) : N/A
@JortRoelofs JortRoelofs added the bug Something isn't working label Aug 9, 2023
@JortRoelofs
Copy link
Author

To add: I just discovered scrobbles are also not properly being registered when a song is on repeat. Just like with the other example, a call to the scrobble view of the Navidrome API is never made.

@nrlght
Copy link

nrlght commented Aug 10, 2023

I can confirm this happens on a Jellyfin server too.

@jeffvli
Copy link
Owner

jeffvli commented Oct 8, 2023

Fixed in #269

@jeffvli jeffvli closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants