Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depviz v0: single page rendering #1

Closed
2 tasks done
jbenet opened this issue Nov 19, 2016 · 4 comments
Closed
2 tasks done

depviz v0: single page rendering #1

jbenet opened this issue Nov 19, 2016 · 4 comments
Assignees

Comments

@jbenet
Copy link
Owner

jbenet commented Nov 19, 2016

I think the first step to make depviz a reality is to make a single page app that does all the following, entirely from clientside:

v0 requirements

Pieces we have

From here we just need to draw the rest of the owl:


depends on #2
depends on #3
depends on #4
depends on #5
depends on #6
depends on #7
depends on #8
depends on #9

wking added a commit to wking/depviz that referenced this issue Nov 20, 2016
The old logic was from [1]:

  var dependentsColor = (item) -> (item.done ? green : red)

But the screenshot in depviz.mocks.011.jpg shows grey dependents
indicators for jbenet#1 and jbenet#7 (neither of which have dependencies).

[1]: jbenet#10
wking added a commit to wking/depviz that referenced this issue Nov 20, 2016
The old logic was from [1]:

  var dependentsColor = (item) -> (item.done ? green : red)

But the screenshot in depviz.mocks.011.jpg shows grey dependents
indicators for jbenet#1 and jbenet#7 (neither of which have dependencies).

[1]: jbenet#10
wking added a commit to wking/depviz that referenced this issue Nov 24, 2016
The old logic was from [1]:

  var dependentsColor = (item) -> (item.done ? green : red)

But the screenshot in depviz.mocks.011.jpg shows grey dependents
indicators for jbenet#1 and jbenet#7 (neither of which have dependencies).

[1]: jbenet#10
wking added a commit to wking/depviz that referenced this issue Nov 24, 2016
It has a more interesting dependency tree.
@wking
Copy link
Collaborator

wking commented Nov 26, 2016

Is this missing a depends on #7? #7 is in the same boat as #4, #5, and #6, but maybe you're intentionally excluding it from the v0 requirements?

@jbenet
Copy link
Owner Author

jbenet commented Nov 28, 2016

I was excluding it, but now that we have it, i've added it :) 👍

@wking
Copy link
Collaborator

wking commented Dec 2, 2016

All the dependencies for this are closed, so I'm closing this issue (which will clear out a large chunk of the github.com/jbenet/depviz graph ;). Feel free to spin off new issues for outstanding requirements / improvements.

@wking wking closed this as completed Dec 2, 2016
@jbenet
Copy link
Owner Author

jbenet commented Dec 5, 2016

fantastic! :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants