Skip to content

Commit

Permalink
DepIndicators: Neutral DependentsIndicator with zero dependents
Browse files Browse the repository at this point in the history
The old logic was from [1]:

  var dependentsColor = (item) -> (item.done ? green : red)

But the screenshot in depviz.mocks.011.jpg shows grey dependents
indicators for jbenet#1 and jbenet#7 (neither of which have dependencies).

[1]: jbenet#10
  • Loading branch information
wking committed Nov 20, 2016
1 parent c7f45c8 commit 5128706
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/DepIndicators.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ class RelatedIndicator extends Component {

class DependentsIndicator extends Component {
render() {
var color = this.props.done ? Green : Red;
var color = Neutral;
if (this.props.dependents) {
color = this.props.done ? Green : Red;
}
var attributes = {};
if (this.props.transform) {
attributes.transform = this.props.transform;
Expand Down

0 comments on commit 5128706

Please sign in to comment.