Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add App Route: Github Issues #4

Closed
jbenet opened this issue Nov 19, 2016 · 1 comment
Closed

Add App Route: Github Issues #4

jbenet opened this issue Nov 19, 2016 · 1 comment

Comments

@jbenet
Copy link
Owner

jbenet commented Nov 19, 2016 •
edited
Loading

Make this route work:

/http/github.com/<user>/<repo>/issues/<issue>

depends on #3
depends on #11
@jbenet jbenet mentioned this issue Nov 19, 2016
Closed
2 tasks
wking added a commit to wking/depviz that referenced this issue Nov 25, 2016
@wking
GitHub: Add canonicalization support for {user}/{repo}/issues/{number}
5e046a1 
And the /pull/ form as well.  Juan requested both of these [1,2],
presumably to allow for easier copy-pasting.  In both cases, redirect
them to the canonical-URI for the issue/pull in question.

When the user does enter one of these non-canonical keys, use an
onEnter handler to redirect them to the canonical path.

[1]: jbenet#4
[2]: jbenet#5
wking added a commit to wking/depviz that referenced this issue Nov 25, 2016
@wking
GitHub: Add canonicalization support for {user}/{repo}/issues/{number}
fe297ae 
And the /pull/ form as well.  Juan requested both of these [1,2],
presumably to allow for easier copy-pasting.  In both cases, redirect
them to the canonical-URI for the issue/pull in question.

When the user does enter one of these non-canonical keys, use an
onEnter handler to redirect them to the canonical path.

[1]: jbenet#4
[2]: jbenet#5
wking added a commit to wking/depviz that referenced this issue Nov 25, 2016
@wking
GitHub: Add canonicalization support for {user}/{repo}/issues/{number}
1acdcf6 
And the /pull/ form as well.  Juan requested both of these [1,2],
presumably to allow for easier copy-pasting.  In both cases, redirect
them to the canonical-URI for the issue/pull in question.

When the user does enter one of these non-canonical keys, use an
onEnter handler to redirect them to the canonical path.

[1]: jbenet#4
[2]: jbenet#5
wking added a commit to wking/depviz that referenced this issue Nov 26, 2016
@wking
GitHub: Add canonicalization support for {user}/{repo}/issues/{number}
37acdca 
And the /pull/ form as well.  Juan requested both of these [1,2],
presumably to allow for easier copy-pasting.  In both cases, redirect
them to the canonical-URI for the issue/pull in question.

When the user does enter one of these non-canonical keys, use an
onEnter handler to redirect them to the canonical path.

[1]: jbenet#4
[2]: jbenet#5
@wking
Copy link
Collaborator

wking commented Nov 26, 2016

Done in #11 (although it redirects to the canonical form without /issues). Can we either add a depends on #11 or merge #11 and close this?

@wking wking mentioned this issue Nov 26, 2016
Merged
wking added a commit to wking/depviz that referenced this issue Nov 28, 2016
@wking
GitHub: Add canonicalization support for {user}/{repo}/issues/{number}
0379d36 
And the /pull/ form as well.  Juan requested both of these [1,2],
presumably to allow for easier copy-pasting.  In both cases, redirect
them to the canonical-URI for the issue/pull in question.

When the user does enter one of these non-canonical keys, use an
onEnter handler to redirect them to the canonical path.

[1]: jbenet#4
[2]: jbenet#5
@jbenet jbenet closed this as completed Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbenet @wking