Create a new pull request by comparing changes across two branches #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are hitting a remote server which sometimes starts failing randomly on CI. They need to be rewritten to use a local server and have `/etc/hosts` setup that remaps relevants URLs.
Adds a lazily created code cache to `deno compile` by default. The code cache is created on first run to a single file in the temp directory and is only written once. After it's been written, the code cache becomes read only on subsequent runs. Only the modules loaded during startup are cached (dynamic imports are not code cached). The code cache can be disabled by compiling with `--no-code-cache`.
Before: ~100ms, After: ~40ms for a hello world Closes #26914
This PR removes the public Deno.tracing.Span API. We are not confident we can ship an API that is better than the `@opentelemetry/api` API, because V8 CPED does not support us using `using` to manage span context. If this changes, we can revisit this decision. For now, users wanting custom spans can instrument their code using the `@opentelemetry/api` API and `@deno/otel`. This PR also speeds up the OTEL trace generation by a 30% by using Uint8Array instead of strings for the trace ID and span ID.
Calling `promisify(generateKeyPair)` didn't work as expected. It requires a custom promisify implementation. This was easy to fix thanks to the excellent debugging investigation in #26910 Fixes #26910 Co-authored-by: Bartek Iwańczuk <[email protected]>
This commit makes http server parameters configurable on the extension initialization via two callbacks users can provide. The main motivation behind this change is to allow `deno_http` users to tune the HTTP/2 server to suit their needs, although Deno CLI users will not benefit from it as no JavaScript interface is exposed to set these parameters currently. It is up to users whether to provide hook functions. If not provided, the default configuration from hyper crate will be used.
This commit makes HTTP client parameters used in `fetch` API configurable on the extension initialization via a callback `client_builder_hook` that users can provide. The main motivation behind this change is to allow `deno_fetch` users to tune the HTTP/2 client to suit their needs, although Deno CLI users will not benefit from it as no JavaScript interface is exposed to set these parameters currently. It is up to users whether to provide a hook function. If not provided, the default configuration from hyper crate will be used. Ref #26785
This commit adds support for "dependencies" in `deno task` subcommand:
```jsonc
{
"tasks": {
"build": "deno run -RW build.ts",
"generate": "deno run -RW generate.ts",
"serve": {
"command": "deno run -RN server.ts",
"dependencies": ["build", "generate"]
}
}
}
```
Executing `deno task serve` will first execute `build` and `generate`
tasks (in parallel) and once both complete the `serve` task will be executed.
Number of tasks run in parallel is equal to the no of cores on the
machine, and respects `DENO_JOBS` env var if one is specified.
Part of #26462
---------
Co-authored-by: Bartek Iwańczuk <[email protected]>
Co-authored-by: Marvin Hagemeister <[email protected]>
The issue was this package had an import like: `".//index.js"` and we resolved that as specified, but node normalizes it to `"./index.js"` so we have to copy node.
…l generation logic (#26885)
This commit adds support for .sql files in "deno fmt" subcommand. Closes: #25024 --------- Signed-off-by: m4rc3l05 <[email protected]> Co-authored-by: Bartek Iwańczuk <[email protected]>
```
> deno compile --allow-read=. --include data-file.txt main.js
```
This only applies to files on the filesystem. For remote modules, that's
going to have to wait for `import ... from "./data.txt" with { "type":
"bytes" }` or whatever it will be.
Support for Wasm modules.
Note this implements the standard where the default export is the
instance (not the module). The module will come later with source phase
imports.
```ts
import { add } from "./math.wasm";
console.log(add(1, 2));
```
…tions (#26551) We should track dependencies in `jsxImportSource`, `jsxImportSourceTypes`, and `types`. That way, for example, if someone removes or changes the `jsxImportSource` then we can remove those items from the lockfile.
Closes #26181 --------- Co-authored-by: Bartek Iwańczuk <[email protected]>
This commit adds `--eval` flag to `deno task` subcommand. This flag allows to evaluate provided "task name" as a task itself, effectively allowing to use `deno_task_shell` from the command line. Also fixes shebang parsing for `node_modules/.bin/` entries to handle `#!/usr/bin/node -S node` in addition to `#!/usr/bin/node node`. Closes #26918
This commit improves permission prompts by adding an option to print a full trace of where the permissions is being requested. Due to big performance hint of stack trace collection, this is only enabled when `DENO_TRACE_PERMISSIONS` env var is present. Closes #20756 --------- Co-authored-by: Bartek Iwańczuk <[email protected]>
Some crucial fixes have not yet been released, so I forked it for the time being.
Closes #20487 Currently spelled ``` deno outdated ``` and ``` deno outdated --update ``` Works across package.json and deno.json, and in workspaces. There's a bit of duplicated code, I'll refactor to reduce this in follow ups ## Currently supported: ### Printing outdated deps (current output below which basically mimics pnpm, but requesting feedback / suggestions) ``` deno outdated ```  ### Updating deps semver compatible: ``` deno outdated --update ``` latest: ``` deno outdated --latest ``` current output is basic, again would love suggestions  #### Filters ``` deno outdated --update "@std/*" deno outdated --update --latest "@std/* "!@std/fmt" ``` #### Update to specific versions ``` deno outdated --update @std/[email protected] @std/cli@^1.0.3 ``` ### Include all workspace members ``` deno outdated --recursive deno outdated --update --recursive ``` ## Future work - interactive update - update deps in js/ts files - better support for transitive deps Known issues (to be fixed in follow ups): - If no top level dependencies have changed, we won't update transitive deps (even if they could be updated) - Can't filter transitive deps, or update them to specific versions ## TODO (in this PR): - ~~spec tests for filters~~ - ~~spec test for mixed workspace (have tested manually)~~ - tweak output - suggestion when you try `deno update` --------- Co-authored-by: Bartek Iwańczuk <[email protected]>
) This commit adds support for suffix wildcard for `--allow-env` flag. Specifying flag like `--allow-env=DENO_*` will enable access to all environmental variables starting with `DENO_*`. Closes #24847 --------- Co-authored-by: Bartek Iwańczuk <[email protected]> Co-authored-by: David Sherret <[email protected]>
This commit adds workspace support to "deno taks". Two new flags were added: - "--recursive" - allows to run a specified task in workspace members, eg. "deno task --recursive dev" - "--filter" - allows to run a specified task only in specific workspace members, eg. "deno task --recursive --filter 'client/*' dev" "--filter" flag implies "--recursive" flag. Closes #24991 --------- Signed-off-by: Bartek Iwańczuk <[email protected]> Signed-off-by: David Sherret <[email protected]> Co-authored-by: Bartek Iwańczuk <[email protected]> Co-authored-by: Nathan Whitaker <[email protected]> Co-authored-by: David Sherret <[email protected]> Co-authored-by: David Sherret <[email protected]>
This commit adds support for `deno init --npm <package>`. Running this will actually call to `npm:create-<package>` package that is equivalent to running `npm create <package>`. User will be prompted if they want to allow all permissions and lifecycle scripts to be executed. Closes #26461 --------- Signed-off-by: Bartek Iwańczuk <[email protected]> Co-authored-by: crowlkats <[email protected]> Co-authored-by: David Sherret <[email protected]>
This PR adds support for using selectors in the JS linting plugin API. Supported at the moment are: - `Foo Bar` (descendant) - `Foo > Bar` (child combinator) - `Foo + Foo` (next sibling) - `Foo ~ Foo` (subsequent sibling) - `[attr]`, `[attr=value]` (attribute selectors, supported operators: `=`, `!=`, `<`, `>`, `<=`, `>=`) - `:first-child` - `:last-child` - `:nth-child(2)`, `:nth-child(2n + 1)`
Fixes #27435 For some reason this was dividing by 1024 (as if the unit was KB, and we wanted bytes) but the page size is already in bytes.
Currently we only supports 7 ciphers (`aes-(128|192|256)-ecb` and `aes-(128|256)-(cbc|gcm)`) in `node:crypto`, but `crypto.getCiphers` returns other supported cipher names. That confuses `npm:openpgp` package and causes #26875. This PR makes `getCiphers` return actually supported cipher names. With this change, the example given in #26875 can create private and public key files. closes #26875
This commit replaces `Deno.telemetry.MetricsExporter` with `Deno.telemetry.MeterProvider`. Signed-off-by: Luca Casonato <[email protected]> Co-authored-by: snek <[email protected]>
When running selectors for JS linting plugins we would error when encountering an unknown attribute name: ```js // selector Foo[non-existant] // error Error: Missing string id: <number> ``` This was caused by using `0` as the invalid marker, but also overloading `0` with an actual node type. So the fix is to reserve `0` as the invalid marker and move the property type to the next index.
Addresses the review feedback in #27416 . - Hoist the buffer max size variable to make it less confusing - Remove manual AST field counter in favour of an explicit "commit schema" step which writes the actual field count.
Add missing `inspector/promises` in node builtin module list, that causes types checking error.
Closes #26643 --------- Co-authored-by: Divy Srivastava <[email protected]>
This changes the cli to mostly use `std::fs` via `sys_traits` instead of the implemention of `deno_fs::FileSystem`.
This PR changes CI to build denort with a separate, new build profile
`release-slim` that disables unwinding and strips symbols. This reduces
the size of denort by about 10%
current denort:
```
FILE SIZE VM SIZE
-------------- --------------
58.1% 39.3Mi 57.9% 39.3Mi __TEXT,__text
31.5% 21.3Mi 31.4% 21.3Mi __TEXT,__const
2.5% 1.68Mi 2.5% 1.68Mi __DATA_CONST,__const
2.4% 1.62Mi 2.4% 1.62Mi __TEXT,__eh_frame
2.4% 1.60Mi 2.4% 1.60Mi __TEXT,__gcc_except_tab
0.9% 610Ki 0.9% 610Ki __TEXT,__cstring
0.8% 536Ki 0.8% 536Ki Code Signature
0.7% 507Ki 0.7% 507Ki __TEXT,__unwind_info
0.3% 207Ki 0.3% 207Ki Function Start Addresses
0.2% 165Ki 0.2% 165Ki __DATA,__data
0.0% 0 0.2% 153Ki __DATA,__bss
0.1% 51.0Ki 0.1% 51.0Ki Rebase Info
0.1% 45.3Ki 0.1% 45.3Ki __TEXT,__literals
0.0% 31.4Ki 0.1% 36.8Ki [15 Others]
0.0% 25.6Ki 0.0% 25.7Ki [__TEXT]
0.0% 19.3Ki 0.0% 20.2Ki [__DATA]
0.0% 8.11Ki 0.0% 8.11Ki Lazy Binding Info
0.0% 8 0.0% 8.08Ki [__LINKEDIT]
0.0% 6.84Ki 0.0% 6.84Ki Symbol Table
0.0% 5.55Ki 0.0% 5.55Ki String Table
0.0% 5.53Ki 0.0% 5.53Ki __TEXT,__ustring
100.0% 67.6Mi 100.0% 67.8Mi TOTAL
```
built with this PR:
```
FILE SIZE VM SIZE
-------------- --------------
59.6% 36.6Mi 59.5% 36.6Mi __TEXT,__text
34.6% 21.3Mi 34.5% 21.3Mi __TEXT,__const
2.7% 1.68Mi 2.7% 1.68Mi __DATA_CONST,__const
1.0% 610Ki 1.0% 610Ki __TEXT,__cstring
0.8% 487Ki 0.8% 487Ki Code Signature
0.3% 193Ki 0.3% 193Ki Function Start Addresses
0.3% 165Ki 0.3% 165Ki __DATA,__data
0.0% 0 0.2% 153Ki __DATA,__bss
0.2% 152Ki 0.2% 152Ki __TEXT,__unwind_info
0.1% 69.5Ki 0.1% 69.5Ki __TEXT,__eh_frame
0.1% 50.9Ki 0.1% 50.9Ki Rebase Info
0.1% 45.3Ki 0.1% 45.3Ki __TEXT,__literals
0.1% 34.1Ki 0.1% 39.5Ki [15 Others]
0.0% 19.3Ki 0.0% 20.2Ki [__DATA]
0.0% 19.6Ki 0.0% 19.7Ki [__TEXT]
0.0% 16.6Ki 0.0% 16.6Ki __TEXT,__gcc_except_tab
0.0% 8.09Ki 0.0% 8.09Ki Lazy Binding Info
0.0% 8 0.0% 7.69Ki [__LINKEDIT]
0.0% 6.83Ki 0.0% 6.83Ki Symbol Table
0.0% 5.77Ki 0.0% 5.77Ki [__DATA_CONST]
0.0% 5.53Ki 0.0% 5.53Ki __TEXT,__ustring
100.0% 61.4Mi 100.0% 61.6Mi TOTAL
```
A caveat is that this will increase release build times in CI since it
requires building twice - once with unwinding and once without
The tags were being sorted in a random order due to the package_reqs hashmap
…27511) Decouples permissions from the npm resolvers (towards moving the resolvers out of the cli crate)
This is in preparation for extracting out these functions from the CLI crate. A side benefit is these functions will now work in Wasm.
The two places mentioned in the issue are now consolidated. Closes #24385
To make sure the servers are torn down when they throw an error during test execution.
…27533) Instead of hard erroring, we now surface module not found errors as TypeScript diagnostics (we have yet to show the source code of the error, but something we can improve over time).
GulajavaMinistudio
merged commit 3eba60b
into
javascript-indonesias:main
6 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.