Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(task): add --eval flag #26943

Merged
merged 9 commits into from
Nov 20, 2024
Merged

feat(task): add --eval flag #26943

merged 9 commits into from
Nov 20, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Nov 19, 2024 •
edited
Loading

This commit adds --eval flag to deno task subcommand.

This flag allows to evaluate provided "task name" as a task itself,
effectively allowing to use deno_task_shell from the command line.

Also fixes shebang parsing for node_modules/.bin/ entries to handle
#!/usr/bin/node -S node in addition to #!/usr/bin/node node.

Closes #26918

@bartlomieju
Copy link
Member Author

CC @benmccann

nathanwhit
nathanwhit approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 318dd3c into denoland:main Nov 20, 2024
17 checks passed
@bartlomieju bartlomieju deleted the deno_task_eval branch November 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package manager equivalent of pnpm exec, yarn exec, etc.
2 participants
@bartlomieju @nathanwhit