refactor: update deno_doc, use prismjs, remove internal reference html generation logic #26885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Nov 16, 2024
dsherret
reviewed
Nov 16, 2024
we removed a bunch recently. ammonia was removed thinking it wasnt necessary, however tha tbroke various things, so thats just reintroducing it |
dsherret
reviewed
Nov 18, 2024
| "regex", | ||
| "serde", | ||
| "serde-wasm-bindgen", |
There was a problem hiding this comment.
Probably the wasm build of deno_doc should be separated into a different crate so that serde-wasm-bindgen doesn't confusingly show up here. We've done it in the other crates and it's a bit cleaner.
dsherret
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.