Sonify plugin updates #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove magnitude units from display units list
…dant GlobalDisplayUnitChange broadcast (spacetelescope#3138) * observe display traitlets separately * . * remove redundant broadcast * code style
* Remove incorrect moveaxis call in spectrum1d_3d parser * Working on correcting expected test results * Continuing to work on tests * Update spectral extraction tests * Update aperphot test * Changelog * Make one cubeviz mouseover test sensitive to axis swap * Update comment * Update jdaviz/configs/cubeviz/plugins/tests/test_parsers.py
Remilestone 3133 to 4.0
because it is spamming the app
BUG: Remove spammy snackbar message
* TST: Modify test to expose bug in main * Fix the bug and add more tests * Maybe should not backport * Fix XOR logic flaw and add more tests. Co-authored-by: Jesse Averbukh <[email protected]> * Simplify lo/hi logic Co-authored-by: Brett M. Morris <[email protected]> --------- Co-authored-by: Jesse Averbukh <[email protected]> Co-authored-by: Brett M. Morris <[email protected]>
…scope#3118) * aperture photometry plugin listens to unit conversion * pllim minor edits review comment Allow per-wave to/from per-freq for most cases Co-authored-by: Clare Shanahan <[email protected]> * TST: Update result that changed because of spacetelescope#3133 --------- Co-authored-by: P. L. Lim <[email protected]>
and devdeps clean-up
* POC: plugin API hints demo * store plugin state in metadata "history" * button to toggle API hints (only hooked up for gaussian smooth for now) * implement to_script method * might want to move to the UI side if we want to control the order and have a copy button * include data definition and write to script in metadata * rename show_api_hints > api_hints * improved styling and connect add_to_viewer * rename api_hints > api_hints_enabled * generalize and implement across multiple plugins * codestyle and fix rebase * .ignore-api-hint > explicitly set .api-hint * use plugin-switch component for visibility switches in plot options * implement for moment maps and specviz2d spec extract * tooltip for toggle button * fix behavior for switches * separate component for slider header * fix styling for editable select * brief mention in docs * changelog entry * don't show toggle button when not in notebook/lab * defer to_script functionality * implement/update additional plugins * partial implementation for dq plugin * plugin-color-picker and plugin-slider components
TST: photutils nightly wheel, devdeps clean-up
Fix dtype error with numpy 2.1
* update method called by zoom callbacks to include logic to skip callback when histogram is not set to follow zoom-limits * changelog entry * zoom-limits handled independently instead of relying on empty msg
update docs links
* change GlobalDisplayUnitChanged axis to spectral_y for clarity * change messaging * . * broadcast 3 messages * update spectral extraction plugin to listen to unit change messages * add args * some changes in aperture photometry to avoid unnecessary unit conversions * revert changes to aperture phot * code style and change log * . * update_uc_messaging * . * removed unused var * remove config check * fix model fitting * update function selection * fix model fitting
…acetelescope#3154) * Disallow negative counts conversion factor in not-so-simple-anymore-too-bad aperture photometry plugin. * Fancier front-end checks. Co-authored-by: Kyle Conroy <[email protected]> --------- Co-authored-by: Kyle Conroy <[email protected]>
* re-add untranslatable units, add translation equivalencies * readd untranslatable units to app defined units * fix rebase, enable untranslatable units, testing and coords needs work * fix styling * resolve spectrum-viewer mouseover, image-viewers need work * generalize flux_conversion, enable untranslatable units, temporarily us mouseover global messages * change log entry, update test_utils.py tests * increase test coverage * seperate flux conversion and transitive units, remove duplicate units, test coverage * remove duplicate/reversed units * implement commented changes * update tests * address review comments, begin work on spectral extraction issue * resolve failing tests and spectral extraction issue
…cope#3319) * Track loaded mask cube in cubeviz * First pass at handling mask cube in extraction * Fix type * Add changelog * Handle mask cubes that have NaNs instead of 0s * Act on copy of this mask array * Don't save DQ array as loaded_mask for JWST * Add snackbar warning and note in docs * codestyle * Add extraction test on file with mask * Codestyle
* example data update for B16 * correction to package names
Fix linkcheck
… tqdm use and import, and use main branch strauss which should now work for JDAViz!
Jt listener pre merge changes
…spacetelescope#3353) * rdm compatibility, move romandeps test to CI workflows * Fix ci_workflows.yml --------- Co-authored-by: P. L. Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds:
Save sonified cube so it does not need to be created multiple timesChange log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.