Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove magnitude units from display units list #3140

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

gibsongreen
Copy link
Contributor

Description

This pull request is to address removing magnitude units from the Unit Conversion plugin, as there may be incorrect scientific calculation made in spectral extraction and aperture photometry when a magnitude unit is selected.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@gibsongreen gibsongreen added this to the 4.0 milestone Aug 8, 2024
@gibsongreen gibsongreen added cubeviz trivial Only needs one approval instead of two labels Aug 8, 2024
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the best if we want to preserve sanity. Thanks!

@pllim pllim added no-changelog-entry-needed changelog bot directive Affects-dev changelog bot directive labels Aug 8, 2024
@pllim pllim enabled auto-merge August 8, 2024 15:23
@pllim pllim merged commit 66633d3 into spacetelescope:main Aug 8, 2024
36 of 39 checks passed
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (f8cd410) to head (7254756).
Report is 135 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3140   +/-   ##
=======================================
  Coverage   88.83%   88.83%           
=======================================
  Files         112      112           
  Lines       17430    17432    +2     
=======================================
+ Hits        15484    15486    +2     
  Misses       1946     1946           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects-dev changelog bot directive cubeviz no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants