Disallow negative counts conversion factor in Aperture Photometry

[pllim]

Description

This pull request is to disallow negative counts conversion factor in Aperture Photometry plugin.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)? 🐱

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (d71dc91) to head (d0001d1).
Report is 126 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3154      +/-   ##
==========================================
+ Coverage   88.82%   88.83%   +0.01%     
==========================================
  Files         112      112              
  Lines       17569    17571       +2     
==========================================
+ Hits        15605    15609       +4     
+ Misses       1964     1962       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kecnry]

Just one clarification question, otherwise looks good to me, thanks!

[bmorris3]

Thank you, this will do it!

[pllim]

Thanks for the reviews!