fix deep dependency graph not show in uiEmbed=v0 mode #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leroy-chen
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
leroy-chen
force-pushed
the
master
branch
2 times, most recently
from
b9f2d52
to
8a56bc3
Compare
Signed-off-by: leroy-chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
==========================================
+ Coverage 95.10% 95.12% +0.02%
==========================================
Files 231 231
Lines 7103 7103
Branches 1709 1752 +43
==========================================
+ Hits 6755 6757 +2
+ Misses 342 340 -2
Partials 6 6
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Jun 17, 2021
leroy-chen
force-pushed
the
master
branch
5 times, most recently
from
022919c
to
d359d5e
Compare
add an new classname when use uiEmbed mode Signed-off-by: leroy-chen <[email protected]>
|
@rubenvp8510 could you review? |
rubenvp8510
reviewed
Sep 8, 2021
…the `top: var(--nav-height);` rule.and remove this from class .Page--content. change new added class name to .Page--content--no-embedded,just keep the `top: var(--nav-height);` rule.and remove this from class .Page--content. Signed-off-by: leroy-chen <[email protected]>
leroy-chen
force-pushed
the
master
branch
2 times, most recently
from
bf557c5
to
46737f8
Compare
fix ci lint error Signed-off-by: leroy-chen <[email protected]>
rubenvp8510
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix deep dependency graph not show in uiEmbed=v0 mode
Which problem is this PR solving?
Short description of the changes