Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deep dependency graph not show in uiEmbed=v0 mode #768

Merged
merged 11 commits into from
Oct 14, 2021
Merged

fix deep dependency graph not show in uiEmbed=v0 mode #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
77335fe
fix issue #719
leroy-chen Jun 17, 2021
3c2ca1d
add an new classname when use uiEmbed mode
leroy-chen Jul 16, 2021
89f0363
Merge branch 'master' into master
leroy-chen Jul 16, 2021
ab8ccd5
Merge branch 'master' into master
leroy-chen Jul 26, 2021
4d6da5f
Merge branch 'master' into master
leroy-chen Aug 12, 2021
0101ad3
Merge branch 'master' into master
rubenvp8510 Sep 8, 2021
c43afa9
change new added class name to .Page--content--no-embedded,just keep …
leroy-chen Sep 16, 2021
20ecd1e
Merge branch 'master' into master
leroy-chen Sep 26, 2021
b0a464d
Merge branch 'master' into master
leroy-chen Sep 28, 2021
46737f8
Merge branch 'master' into master
leroy-chen Oct 8, 2021
a629277
fix ci lint error
leroy-chen Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/jaeger-ui/src/components/App/Page.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@ limitations under the License.
min-height: calc(100% - var(--nav-height));
position: absolute;
right: 0;
}

.Page--content--no-embedded {
top: var(--nav-height);
}
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/App/Page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class PageImpl extends React.Component<TProps> {

render() {
const { embedded } = this.props;
const contentCls = cx({ 'Page--content': !embedded });
const contentCls = cx({ 'Page--content': true, 'Page--content--no-embedded': !embedded });
return (
<div>
<Helmet title="Jaeger UI" />
Expand Down