Skip to content

Commit

Permalink
fix deep dependency graph not show in uiEmbed=v0 mode (#768)
Browse files Browse the repository at this point in the history
* fix issue #719

Signed-off-by: leroy-chen <[email protected]>

* add an new classname when use uiEmbed mode

add an new classname when use uiEmbed mode

Signed-off-by: leroy-chen <[email protected]>

* change new added class name to .Page--content--no-embedded,just keep the `top: var(--nav-height);` rule.and remove this from class .Page--content.

change new added class name to .Page--content--no-embedded,just keep the `top: var(--nav-height);` rule.and remove this from class .Page--content.

Signed-off-by: leroy-chen <[email protected]>

* fix ci lint error

fix ci lint error

Signed-off-by: leroy-chen <[email protected]>

Co-authored-by: Ruben Vargas <[email protected]>
  • Loading branch information
leroy-chen and rubenvp8510 authored Oct 14, 2021
1 parent e531c04 commit 56c2911
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/jaeger-ui/src/components/App/Page.css
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,8 @@ limitations under the License.
min-height: calc(100% - var(--nav-height));
position: absolute;
right: 0;
}

.Page--content--no-embedded {
top: var(--nav-height);
}
2 changes: 1 addition & 1 deletion packages/jaeger-ui/src/components/App/Page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class PageImpl extends React.Component<TProps> {

render() {
const { embedded } = this.props;
const contentCls = cx({ 'Page--content': !embedded });
const contentCls = cx({ 'Page--content': true, 'Page--content--no-embedded': !embedded });
return (
<div>
<Helmet title="Jaeger UI" />
Expand Down

0 comments on commit 56c2911

Please sign in to comment.