Use builtin vscode.open command in tracked explorer tree #807
Conversation
| "description": "%config.noOpenUnsupported.description%", | ||
| "type": "boolean", | ||
| "default": false | ||
| }, |
There was a problem hiding this comment.
[F] We no longer need this option which is good.
There was a problem hiding this comment.
I previously added "Don't Show Again" options for some of our (more frequent / annoying) toast popups as per the notifications section of the extension guidelines
| error => { | ||
| if ( | ||
| error.message.includes( | ||
| 'File seems to be binary and cannot be opened as text' |
There was a problem hiding this comment.
[C] Not relying on free text from an error message anymore, also good.
| expect(mockPull).not.to.be.called | ||
| expect( | ||
| mockShowInformationMessage, | ||
| 'should show the user an information prompt' |
There was a problem hiding this comment.
[F] The only difference with this test is the added expect breadcrumb. They should make it easier to grok what is going on next time we come round.
mattseddon
force-pushed
the
improve-tracked-explorer-open
branch
from
aa1a8b2 to
e2628b9
Compare
|
Code Climate has analyzed commit e2628b9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.0% (0.0% change). View more on Code Climate. |
|
related to #569 |
2/2
master<- #806 <- thisAs detailed in the description of #806 there was a better way of opening files from the tracked explorer tree.
This PR uses the vscode builtin
vscode.opencommand to open files from the tree with the left click mouse action. I have also deleted all of the code that we no longer need as a result.Demo:
Screen.Recording.2021-09-14.at.2.23.43.pm.mov
Screen.Recording.2021-09-14.at.2.25.53.pm.mov
For context the history of this goes back to #528 (and beyond).