Improve tracked tree open file error notifications #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
changed the title
mattseddon
changed the title
mattseddon
changed the title
mattseddon
commented
Jun 4, 2021
|
|
||
| if ( | ||
| error.message.includes( | ||
| 'File seems to be binary and cannot be opened as text' |
There was a problem hiding this comment.
[F] There is nothing in the error object outside of the message that is useful in terms of deciphering what the error was. Relying on "free text" is risky and brittle but there is no other option outside of removing openResource altogether.
mattseddon
commented
Jun 4, 2021
| it('should call showErrorMessage when dvc.views.trackedExplorerTree.openFile tries to open a binary file', async () => { | ||
| const path = join(dvcDemoPath, 'model.pt') | ||
| const uri = Uri.file(path) | ||
| it('should only call showInformationMessage when trying to open a binary file without the no binary errors option set', async () => { |
There was a problem hiding this comment.
[F] This is when given, when, then would be super handy
mattseddon
force-pushed
the
improve-open-resource-errors
branch
from
698c6e4 to
979f707
Compare
rogermparent
approved these changes
Jun 4, 2021
|
Code Climate has analyzed commit 5e98dd9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.3% (85% is the threshold). This pull request will bring the total coverage in the repository to 90.2% (0.1% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #330 (comment) - The level of the message is too high and there should be different actions based on whether the file is disk or appears binary.
This PR
Demo:
Screen.Recording.2021-06-04.at.5.01.10.pm.mov
LMK if you have any questions, comments, concerns.
Thanks,