Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DVCLive step completed signal file events to trigger experiments and plots data updates #4579

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Aug 28, 2023

Depends on iterative/dvclive#688 and iterative/dvc#9879 being released.

Closes #4528

@mattseddon mattseddon added the bug Something isn't working label Aug 28, 2023
@mattseddon mattseddon self-assigned this Aug 28, 2023
@mattseddon mattseddon marked this pull request as ready for review August 29, 2023 19:38
export const DVCLIVE_STEP_COMPLETED_SIGNAL_FILE = join(
TEMP_EXP_RUN_DIR,
'DVCLIVE_STEP_COMPLETED'
)
Copy link
Member Author

@mattseddon mattseddon Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] This is the new file that gets written to every time a DVCLive step is completed. It will be a file in the dvc root for experiments running in the queue as well (not in their temp directory).

@codeclimate
Copy link

codeclimate bot commented Aug 29, 2023

Code Climate has analyzed commit 622ace8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiments table not updating while experiments are running
2 participants