Add step completed signal file for VS Code #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
add-step-signal
branch
2 times, most recently
from
a0a5b67 to
65fddbf
Compare
mattseddon
commented
Aug 28, 2023
daavoo
reviewed
Aug 28, 2023
2 tasks
daavoo
force-pushed
the
add-step-signal
branch
from
d11b6d5 to
67e1658
Compare
daavoo
reviewed
Aug 29, 2023
| @@ -31,7 +31,7 @@ classifiers = [ | |||
| ] | |||
| dynamic = ["version"] | |||
| dependencies = [ | |||
| "dvc>=2.58.0", | |||
| "dvc>=3.17.0", | |||
daavoo
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVCLive
guide.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
In
vscode-dvc, we have this issue which is caused by VS Code dropping events for files within deeply nested folders when running on a remote machine. This can happen when a user has a slightly nested folder structure and is running experiments in the queue. An example of a file path that should trigger a watcher event but doesn't is:{root}/.dvc/tmp/exps/{tmp_queue_dir}/data/train/metrics.jsonMy suggestion here to the user was for him to update his training script to touch one of the files further up the tree (e.g. the root
dvc.yaml) but we can do the same thing with DVCLive meaning that the extension should be guaranteed to work out of the box for users using DVCLive as a logger if we specifically watch for that file being updated.Depends on iterative/dvc#9879
Demo
https://github.com/iterative/dvclive/assets/37993418/2315beff-f327-4273-bb4c-2658d7dcc64eScreen.Recording.2023-08-28.at.10.01.54.am.mov