Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply product feedback to dvc.yaml snippets #4255

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 11, 2023

Changes based on feedback in #4194 (comment)

Demo

Screen.Recording.2023-07-11.at.10.19.40.am.mov

@mattseddon mattseddon added the product PR that affects product label Jul 11, 2023
@mattseddon mattseddon self-assigned this Jul 11, 2023
@mattseddon mattseddon marked this pull request as ready for review July 11, 2023 00:38
" outs:",
" - ${4:list output(s) of the stage, e.g. model.pkl}"
],
"description": "Minimal stage template for dvc.yaml pipeline"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F] After removing metrics params where the only difference between this and the snippet above. I didn't think it made sense to keep it around.

@mattseddon mattseddon force-pushed the update-snippets branch 2 times, most recently from c0379a1 to 0c305b5 Compare July 11, 2023 00:42
@dberenbaum
Copy link
Contributor

dberenbaum commented Jul 11, 2023

Thanks @mattseddon!

params still doesn't look right to me. From https://dvc.org/doc/user-guide/project-structure/dvcyaml-files#parameters, it should fit one of these patterns:

    params:
      - threshold # track specific param (from params.yaml)
      - nn.batch_size
      - myparams.yaml: # track specific params from custom file
          - epochs
      - config.json: # track all parameters in this file

The items under params: can't be simply filenames. Each item in the list must be either a parameter name or a filename dict with parameter values (or an empty dict to include all parameter values from the file).

@mattseddon
Copy link
Member Author

Thanks @mattseddon!

params still doesn't look right to me. From https://dvc.org/doc/user-guide/project-structure/dvcyaml-files#parameters, it should fit one of these patterns:

    params:
      - threshold # track specific param (from params.yaml)
      - nn.batch_size
      - myparams.yaml: # track specific params from custom file
          - epochs
      - config.json: # track all parameters in this file

The items under params: can't be simply filenames. Each item in the list must be either a parameter name or a filename dict with parameter values (or an empty dict to include all parameter values from the file).

updated to give the simplest example

@mattseddon mattseddon enabled auto-merge (squash) July 11, 2023 22:07
@codeclimate
Copy link

codeclimate bot commented Jul 11, 2023

Code Climate has analyzed commit 12fad3b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.1% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit 9c546ea into main Jul 11, 2023
@mattseddon mattseddon deleted the update-snippets branch July 11, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants