-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dvc.yaml
generation
#4194
Comments
Hey @julieg18 ! 👋 Edited for clarifying : UI dvc pipeline might take into account dependency management and linearity for better user control in terms of pipeline design. The main mental model under this comment is to pinpoint the consecuences and differences in between WHAT a stage is and HOW a stage is designed from the user perspective. Principle taken from engineering section 100 mental models book. This might influence two of the three points of Improvement .
Would you think about how this might be in UI terms or construct this having this common roadblock in mind? Thinking about this, there might be 3 cases
I might think if the final design should lead to the pipeline to be created linearly to ensure that is constructed correctly . I had at some point this idea of putting two buttons - one for the dependency and another for the output - and select them from a folder , but that should entail that they were previously created... maybe some ideas from this ? Anyway , maybe these thoughts expand on more complex pipelines, but having this in mind might avoid certain frustation / churn stuff from DS . Hope you are having as much fun these days as I am in the Open! |
In #4233 I have added some helper snippets that can be used for building pipelines. DemoScreen.Recording.2023-07-07.at.11.30.40.am.movWe can extend these to include other parts of the pipeline. E.g. plots. cc @dberenbaum, @daavoo WDYT? Please LMK if there is anything that can be done to improve the copy in the snippets 🙏🏻. edit: PTAL at #4234 & #4235 as well. I also intend to add snippets for each of the frameworks supported by DVCLive but that work will be done under a separate issue. |
Thanks @mattseddon! Some thoughts:
|
Thanks for the feedback @dberenbaum. All good points.
No worries, I will drop
I will update this too.
If we show this message as a popup it will be easily dismissed and the information could be missed/lost (and there is no undo button). Happy to update if you want but it was a conscious decision to put the information into the file.
Generally, if I was going to be making snippets for a group/team I would not put any suggestions into the template but I see these snippets as more of an educational piece to get people familiar with the layout before they switch over to completions. My first instinct was to use the format The only outstanding question is on whether or not to switch to a popup for the message written at the top of the Again, it would be good to get iterative/dvcyaml-schema#40 sorted out sooner rather than later 🙏🏻. |
Sounds good, @mattseddon. I was thinking a pop-up in addition to having it in the file, but I think it's fine as is. Your call on that. |
Current
UI:
Generated
dvc.yaml
or update to already created file:Improvements
dvc.yaml
for example.dvc.yaml
, giving a more in-depth explanation ofdvc.yaml
with some configuration examplesRelated #3331
The text was updated successfully, but these errors were encountered: