Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dvc.yaml top level plot snippets #4234

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented Jul 7, 2023

2/3 main <- #4233 <- this <- #4235

Part of #4194

Follow up from the previous PR. Adds snippets that can be used to generate top-level plots.

Demo

Screen.Recording.2023-07-07.at.2.09.14.pm.mov
Screen.Recording.2023-07-07.at.2.11.47.pm.mov
Screen.Recording.2023-07-07.at.2.12.48.pm.mov

@mattseddon mattseddon added the product PR that affects product label Jul 7, 2023
@mattseddon mattseddon self-assigned this Jul 7, 2023
@mattseddon mattseddon changed the base branch from main to add-dvc-yaml-snippets July 7, 2023 04:26
@mattseddon mattseddon marked this pull request as ready for review July 7, 2023 04:32
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners July 7, 2023 04:32
@mattseddon mattseddon requested a review from shcheklein July 7, 2023 04:32
@mattseddon mattseddon mentioned this pull request Jul 7, 2023
3 tasks
@mattseddon mattseddon force-pushed the add-dvc-yaml-plot-snippets branch from 6db1f8a to 08ec5ba Compare July 7, 2023 06:20
Copy link
Contributor

@julieg18 julieg18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Base automatically changed from add-dvc-yaml-snippets to main July 7, 2023 21:26
@mattseddon mattseddon force-pushed the add-dvc-yaml-plot-snippets branch from 08ec5ba to 1080790 Compare July 7, 2023 22:42
@mattseddon mattseddon enabled auto-merge (squash) July 7, 2023 22:43
@codeclimate
Copy link

codeclimate bot commented Jul 7, 2023

Code Climate has analyzed commit 4d66498 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.2% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon merged commit bb87880 into main Jul 8, 2023
@mattseddon mattseddon deleted the add-dvc-yaml-plot-snippets branch July 8, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product PR that affects product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants