Create shared panels component #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
mattseddon
force-pushed
the
add-shared-component
branch
from
2c22405 to
f6c5d69
Compare
mattseddon
commented
May 30, 2023
| className: string | ||
| } | ||
|
|
||
| export const Panels: React.FC<PanelProps> = ({ className, panels }) => { |
There was a problem hiding this comment.
[F] The reason that I renamed this from Slider is because we already have a slider => webview/src/shared/components/slider/Slider.tsx
This was referenced May 30, 2023
shcheklein
approved these changes
May 30, 2023
sroy3
approved these changes
May 30, 2023
julieg18
approved these changes
May 30, 2023
mattseddon
force-pushed
the
add-shared-component
branch
from
f6c5d69 to
e02ed47
Compare
|
Code Climate has analyzed commit e02ed47 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2%. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/4
main<- #4005 <- this <- #4007 <- #4004This PR creates a shared
<Panels />component that pulls the duplication out of what was previously the<CodeSlider />and<StorageSlider />(which have been renamed).