Add link to show applicable extension for each storage provider #4004
Conversation
| <a | ||
| href={`command:workbench.extensions.search?${encodeURIComponent( | ||
| idQuery | ||
| )}`} |
There was a problem hiding this comment.
[F] This took a long time to workout. I actually had to visit the VS Code codebase to copy the expected format.
Finally found the format at
https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/welcomeGettingStarted/common/media/extensions-web.svg#L44
mattseddon
force-pushed
the
add-show-extension
branch
from
51e112e to
c3f0393
Compare
|
cc @dberenbaum for the demo. It shows the information currently provided per supported storage type. |
| @@ -11,6 +12,10 @@ export const AzureBlobStorage = () => ( | |||
| </a>{' '} | |||
| for details on how to authenticate. | |||
| </p> | |||
| <ShowExtension | |||
There was a problem hiding this comment.
Maybe it's just me as a pretty literal person, but a sentence telling me about the separate extension felt confusing. Do I need this extension to setup DVC remotes? Looking at the comment you linked in #3867, I'm assuming the purpose is to let the user know that installing the corresponding remote extension would make remote setup easier 🤔
Maybe we could make that reasoning more clear? For example, Make setup easier with the Azure Storage extension.
There was a problem hiding this comment.
Maybe we could make that reasoning more clear? For example, Make setup easier with the Azure Storage extension.
Without doing some due diligence I wouldn't make that claim. I am going to see if those extensions expose useful APIs but for now I just wanted to make people aware that they exist.
|
|
||
| return ( | ||
| <p> | ||
| <Icon |
There was a problem hiding this comment.
With this admonition added, there are now 2-3 admonitions stacked up on top of each other in each panel:
This feels hard to read for me but I'm not really seeing an alternative solution besides rewording these into paragraphs instead of admonitions which might not actually make these more readable 🤔
mattseddon
force-pushed
the
add-show-extension
branch
from
c3f0393 to
58d2205
Compare
mattseddon
force-pushed
the
add-show-extension
branch
from
58d2205 to
24c0b77
Compare
|
Code Climate has analyzed commit 24c0b77 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 95.2% (0.0% change). View more on Code Climate. |
4/4
main<- #4005 <- #4006 <- #4007 <- thisRelated to #3867
This PR adds some clickable links to tabs in the
<StorageSlider/>added in #3996. Each link will show the appropriate extension for the storage provider in the extensions view.Demo
Screen.Recording.2023-05-30.at.1.58.39.pm.mov