Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension initialization on Windows (esm imports broken) #3937

Merged
merged 1 commit into from
May 19, 2023

Conversation

mattseddon
Copy link
Member

@mattseddon mattseddon commented May 19, 2023

@mattseddon mattseddon added the bug Something isn't working label May 19, 2023
@mattseddon mattseddon self-assigned this May 19, 2023
@mattseddon mattseddon marked this pull request as ready for review May 19, 2023 02:36
@mattseddon mattseddon requested review from sroy3 and julieg18 as code owners May 19, 2023 02:36
@mattseddon mattseddon requested a review from shcheklein May 19, 2023 02:36
@mattseddon mattseddon force-pushed the fix-windows branch 3 times, most recently from d39c51f to 6dd7089 Compare May 19, 2023 03:47
@codeclimate
Copy link

codeclimate bot commented May 19, 2023

Code Climate has analyzed commit dba707a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 95.0% (0.0% change).

View more on Code Climate.

@mattseddon mattseddon enabled auto-merge (squash) May 19, 2023 04:28
@mattseddon mattseddon merged commit 7f21fb6 into main May 19, 2023
@mattseddon mattseddon deleted the fix-windows branch May 19, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants